Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename fetch_correlation_id to hostga_plugin_correlation_id #2526

Merged
merged 2 commits into from
Mar 7, 2022

Conversation

narrieta
Copy link
Member

@narrieta narrieta commented Mar 4, 2022

No description provided.

@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #2526 (6024e1e) into develop (c42343c) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2526      +/-   ##
===========================================
- Coverage    71.97%   71.95%   -0.02%     
===========================================
  Files          102      102              
  Lines        15188    15188              
  Branches      2403     2403              
===========================================
- Hits         10932    10929       -3     
- Misses        3773     3776       +3     
  Partials       483      483              
Impacted Files Coverage Δ
...protocol/extensions_goal_state_from_vm_settings.py 81.54% <100.00%> (ø)
azurelinuxagent/common/protocol/goal_state.py 96.81% <100.00%> (ø)
azurelinuxagent/common/event.py 85.36% <0.00%> (-0.68%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c42343c...6024e1e. Read the comment docs.

larohra
larohra previously approved these changes Mar 4, 2022
nagworld9
nagworld9 previously approved these changes Mar 7, 2022
"""
The correlation id for the fetch operation (i.e. the call to the HostGAPlugin vmSettings API)
The correlation id for the call to the HostGAPlugin vmSettings API
"""
return self._fetch_correlation_id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why don't we update this too?

@narrieta narrieta dismissed stale reviews from nagworld9 and larohra via 6024e1e March 7, 2022 20:35
@narrieta narrieta merged commit 9a4dd3c into Azure:develop Mar 7, 2022
@narrieta narrieta deleted the correlation-id branch March 7, 2022 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants