Use ExtensionsGoalState.id when checking for changes in extensions #2499
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
dhivyaganesan,
kevinclark19a,
larohra,
nagworld9 and
ZhidongPeng
as code owners
narrieta
commented
Feb 9, 2022
| @@ -2482,6 +2483,17 @@ def __init__(self, return_value=0, side_effect=None): | |||
| self.wait = Mock(return_value=return_value, side_effect=side_effect) | |||
|
|
|||
|
|
|||
| class ExtensionsGoalStateMock(object): | |||
There was a problem hiding this comment.
These tests are using deep internals of the UpdateHandler object; I patched them for now, but eventually they should be updated to use the mock_protocol utilities.
Codecov Report
@@ Coverage Diff @@
## develop #2499 +/- ##
===========================================
+ Coverage 71.80% 71.82% +0.01%
===========================================
Files 101 101
Lines 15076 15080 +4
Branches 2391 2392 +1
===========================================
+ Hits 10826 10831 +5
+ Misses 3769 3766 -3
- Partials 481 483 +2
Continue to review full report at Codecov.
|
nagworld9
reviewed
Feb 11, 2022
nagworld9
approved these changes
Feb 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once Fast Track is enabled we cannot use the incarnation to check for changes in the extensions goal state. Using 'id' instead (this abstracts the incarnation/etag used by WireServer/HostGAPlugin).