Move fetch_vm_settings() to HostPluginProtocol #2486
Conversation
narrieta
requested review from
dhivyaganesan,
kevinclark19a,
larohra,
nagworld9 and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## fast-track #2486 +/- ##
==============================================
- Coverage 71.78% 71.78% -0.01%
==============================================
Files 101 101
Lines 14987 14990 +3
Branches 2388 2389 +1
==============================================
+ Hits 10758 10760 +2
Misses 3742 3742
- Partials 487 488 +1
Continue to review full report at Codecov.
|
| @@ -383,3 +390,174 @@ def _base64_encode(self, data): | |||
| if PY_VERSION_MAJOR > 2: | |||
| return s.decode('utf-8') | |||
| return s | |||
|
|
|||
There was a problem hiding this comment.
Moved from the WireClient, the only difference in the implementation is the use of ResourceGoneError to report 410s (added the exception here because the retry logic needs to be implemented by the caller)
| @@ -862,6 +862,125 @@ def test_should_report(self): | |||
| self.assertEqual(False, actual) | |||
|
|
|||
|
|
|||
| class TestHostPluginVmSettings(HttpRequestPredicates, AgentTestCase): | |||
There was a problem hiding this comment.
Move from test_wire. The implementation is almost identical to the original, but instead of testing via WireClient.update_goal_state() now we test via HostPluginProtocol.fetch_vm_settings()
|
|
||
| # | ||
| # Then we fetch the vmSettings from the HostGAPlugin; the response will include the goal state for extensions. | ||
| # | ||
| vm_settings_goal_state, vm_settings_goal_state_updated = (None, False) | ||
| vm_settings, vm_settings_updated = (None, False) | ||
|
|
||
| if conf.get_enable_fast_track(): |
There was a problem hiding this comment.
Maybe we should consider renaming this flag to get_enable_vm_settings or something.
There was a problem hiding this comment.
The flag controls the Fast Track feature. At this point it only controls the call to vmSettings, but soon it will control other stuff, too, like the handshake with CRP
There was a problem hiding this comment.
In that case, how are we going to handle it if the customer wants to opt-out of fast-track, will we just avoid using vmSettings altogether? In short we're considering vmSettings tantamount to fast-track?
There was a problem hiding this comment.
Yes, if fast track is disabled we will simply use extensionsConfig. That is already implemented in this PR. Yes, vmSettings is fundamental for FastTrack, no fast-track => do not use vmsettings, no vmsettings => do not use fast track.
Some code cleanup. Moved the logic and data structures for the vmSettings request from the WireClient to the HostPluginProtocol.