Don't test for agent log in between tests ETP #2471
Conversation
larohra
requested review from
dhivyaganesan,
kevinclark19a,
nagworld9,
narrieta and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #2471 +/- ##
===========================================
+ Coverage 71.99% 72.01% +0.01%
===========================================
Files 101 101
Lines 15053 15053
Branches 2392 2392
===========================================
+ Hits 10837 10840 +3
+ Misses 3733 3730 -3
Partials 483 483
Continue to review full report at Codecov.
|
| @@ -93,6 +92,21 @@ def check_waagent_log_for_errors(waagent_log=AGENT_LOG_FILE, ignore=None): | |||
| { | |||
| 'message': r"WARNING EnvHandler ExtHandler Dhcp client is not running." | |||
| }, | |||
| # This happens in CENTOS and RHEL when waagent attempt to format and mount the error while cloud init is already doing it | |||
There was a problem hiding this comment.
do we get these errors at all in DCR V2?
There was a problem hiding this comment.
haven't seen it honestly. I just copied the complete ignore list from v1 and copied it in v2.
There was a problem hiding this comment.
we wouldn't expect it, right? sounds like a provisioning error. i'd suggest removing it here and we can always add it back if there is a reason to do so
There was a problem hiding this comment.
makes sense, let me remove it
Description
Currently we were checking for errors in agent log mid-test in ETP. Refactored that to only check at the end and check for relevant errors mid-test
Issue #
PR information
Quality of Code and Contribution Guidelines