Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Report VMSize via Heartbeat telemetry event #2462

Merged
merged 19 commits into from
Feb 9, 2022
Merged

Report VMSize via Heartbeat telemetry event #2462

merged 19 commits into from
Feb 9, 2022

Conversation

kevinclark19a
Copy link
Contributor

@kevinclark19a kevinclark19a commented Jan 7, 2022 •
edited
Loading

Description

Report VMSize from IMDS in each heartbeat telemetry.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jan 7, 2022 •
edited
Loading

Codecov Report

Merging #2462 (1a5dfee) into develop (dd90219) will increase coverage by 0.05%.
The diff coverage is 93.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2462      +/-   ##
===========================================
+ Coverage    71.73%   71.79%   +0.05%     
===========================================
  Files          101      101              
  Lines        15055    15069      +14     
  Branches      2390     2391       +1     
===========================================
+ Hits         10800    10819      +19     
+ Misses        3771     3769       -2     
+ Partials       484      481       -3
Impacted Files Coverage Δ
azurelinuxagent/ga/update.py 88.61% <93.33%> (+0.05%) ⬆️
azurelinuxagent/common/utils/restutil.py 84.36% <0.00%> (+0.32%) ⬆️
azurelinuxagent/ga/collect_telemetry_events.py 91.43% <0.00%> (+1.71%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dd90219...1a5dfee. Read the comment docs.

larohra
larohra reviewed Jan 10, 2022
View reviewed changes
azurelinuxagent/ga/update.py Outdated
@@ -19,6 +19,7 @@
import glob
import json
import os
import platform
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work across all our distros? Like is this package available by default in our whole fleet? Please do a DCR run to be sure of that. Thanks!

narrieta
narrieta reviewed Jan 27, 2022
View reviewed changes
azurelinuxagent/ga/update.py Outdated
@@ -413,6 +419,17 @@ def run(self, debug=False):
self._shutdown()
sys.exit(0)

def _initialize_heartbeat_parameters(self, protocol):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd rename this function, since it does not initialize all the parameters in the heartbeat

azurelinuxagent/ga/update.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/update.py Outdated
self._heartbeat_update_goal_state_error_count,
auto_update_enabled)
auto_update_enabled, self._vm_size)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you post some sample values?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sample?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding the telemetry from a DCR run of the latest code here (also added to the task):

GAVersion OSVersion Message
WALinuxAgent-9.9.9.9 Linux:centos-6.10-Final:2.6.32-754.29.1.el6.x86_64 1;3ED6E59A-F9F6-4682-A819-7689FEAFB75B;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-6.10-Final:2.6.32-754.29.1.el6.x86_64 1;424A914D-0306-498A-BFCC-80AF2CD59BDB;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-6.10-Final:2.6.32-754.29.1.el6.x86_64 0;3ED6E59A-F9F6-4682-A819-7689FEAFB75B;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-6.10-Final:2.6.32-754.29.1.el6.x86_64 1;BC18010E-0EDB-4BF9-B438-3D122B9686FA;2;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-6.10-Final:2.6.32-754.29.1.el6.x86_64 0;BC18010E-0EDB-4BF9-B438-3D122B9686FA;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-7.8.2003-Core:3.10.0-1127.19.1.el7.x86_64 0;91913BE1-160F-44B9-B33B-BA35958622FE;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-7.8.2003-Core:3.10.0-1127.19.1.el7.x86_64 1;A8323227-887B-4B83-B859-894739132791;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-7.8.2003-Core:3.10.0-1127.19.1.el7.x86_64 0;A8323227-887B-4B83-B859-894739132791;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-7.8.2003-Core:3.10.0-1127.19.1.el7.x86_64 1;67A1D036-7313-4E5C-9D7C-3C81DCC4CCCE;1;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:centos-7.8.2003-Core:3.10.0-1127.19.1.el7.x86_64 0;67A1D036-7313-4E5C-9D7C-3C81DCC4CCCE;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-10.11-:4.19.0-18-cloud-amd64 1;9228187B-1E96-40C3-8790-6B85F3D20CFE;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-10.11-:4.19.0-18-cloud-amd64 1;01DAF357-65F3-421E-BB08-00D34C725D0A;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-10.11-:4.19.0-18-cloud-amd64 0;BDA4C75F-0946-4545-B3CA-D4269932EE7A;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-10.11-:4.19.0-18-cloud-amd64 0;01DAF357-65F3-421E-BB08-00D34C725D0A;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-10.11-:4.19.0-18-cloud-amd64 1;BDA4C75F-0946-4545-B3CA-D4269932EE7A;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-10.11-:4.19.0-18-cloud-amd64 0;9228187B-1E96-40C3-8790-6B85F3D20CFE;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-8.11-:3.16.0-10-amd64 0;560738A4-E72F-4A18-B99B-E6E0AA414BEC;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-8.11-:3.16.0-10-amd64 0;099024A0-2958-42E6-B500-60482810C456;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-8.11-:3.16.0-10-amd64 0;C864F6EC-A472-4F53-9C9B-31A175234C1F;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-8.11-:3.16.0-10-amd64 1;099024A0-2958-42E6-B500-60482810C456;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-8.11-:3.16.0-10-amd64 1;560738A4-E72F-4A18-B99B-E6E0AA414BEC;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-8.11-:3.16.0-10-amd64 0;F3522DC6-7D23-472D-9B22-5967A4F1FF48;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-9.13-:4.9.0-16-amd64 0;2CDDFF2A-1D43-4D25-8DCA-EF0DB0742C10;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-9.13-:4.9.0-16-amd64 0;B38F1441-B6E4-458B-AEE8-D3DC7A5BC557;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-9.13-:4.9.0-16-amd64 0;333A2C0B-0FA5-4835-B7B6-AC08D2B2508D;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-9.13-:4.9.0-16-amd64 1;333A2C0B-0FA5-4835-B7B6-AC08D2B2508D;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-9.13-:4.9.0-16-amd64 1;2CDDFF2A-1D43-4D25-8DCA-EF0DB0742C10;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-9.13-:4.9.0-16-amd64 0;D97D8089-4713-47D0-80D6-23960CF71570;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:debian-9.13-:4.9.0-16-amd64 1;D97D8089-4713-47D0-80D6-23960CF71570;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.6-Maipo:3.10.0-957.72.1.el7.x86_64 0;D6797ADE-0AF3-4C96-A8FE-A438FDF53E28;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;A137B8C1-3A8B-49AE-BFD3-69391CFABF32;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;1F96C166-CC1D-4338-BFD9-E1FC0D24CAB4;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;3A881E30-F7F7-46E9-B9EB-DA886293C147;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;74FE6849-DA2B-45F3-8241-8DF54A6EECE4;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;685BD5BE-5FC3-4252-9E21-A55A814A5D89;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;49CBA6E1-4E99-4868-882C-61407047F441;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 1;1F96C166-CC1D-4338-BFD9-E1FC0D24CAB4;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;F579DBE1-D6A2-46D5-942B-10AF127E52D2;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;B990FDC9-9909-4E48-B2A8-8EA72F6721D7;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 0;10DBBD74-7EA5-4BAF-9F77-A808432CF0F3;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-7.8-Maipo:3.10.0-1127.el7.x86_64 1;3A881E30-F7F7-46E9-B9EB-DA886293C147;2;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-8.2-Ootpa:4.18.0-193.65.2.el8_2.x86_64 0;8E3DAA62-DA84-4088-AE75-85324360602C;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-8.2-Ootpa:4.18.0-193.65.2.el8_2.x86_64 0;8F237230-EF1B-4D99-9AA6-870BE734A979;3;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-8.2-Ootpa:4.18.0-193.65.2.el8_2.x86_64 1;D002B3DC-B20E-44B4-B5DA-A8A73E47AA0B;1;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-8.2-Ootpa:4.18.0-193.65.2.el8_2.x86_64 0;D002B3DC-B20E-44B4-B5DA-A8A73E47AA0B;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:redhat-8.2-Ootpa:4.18.0-193.65.2.el8_2.x86_64 1;8E3DAA62-DA84-4088-AE75-85324360602C;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:sles-15.2-:5.3.18-18.47-azure 0;24463F93-5F17-4D55-BCE6-D2974ABD7DF8;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:sles-15.2-:5.3.18-18.47-azure 0;5145EF1B-129F-4061-9082-650797DE23C8;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:sles-15.2-:5.3.18-18.47-azure 0;6ED5A9BF-7462-44D5-9BC8-8A46EB35EEC6;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 1;597883E6-B026-48BD-9CD5-74960D65AC9B;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 0;CFE651EC-9225-4B50-B362-55BD016B2379;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 0;595612F5-B37E-49E5-A3BE-BCE41C1256F3;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 0;C0CBF883-BA1C-4323-A61C-77AC61396F48;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 1;FACCC1BF-2A5B-43A1-AC9A-33AF60315ADC;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 1;2CB47677-26F4-4D4E-BC1D-2008CC8D3377;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 0;67BE212C-BFFA-4019-BD07-F7FC153A4BA4;2;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 0;2CB47677-26F4-4D4E-BC1D-2008CC8D3377;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:suse-12-x86_64:4.12.14-16.85-azure 0;597883E6-B026-48BD-9CD5-74960D65AC9B;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;557F5943-9427-4791-916D-91871554E389;2;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;7A709776-91D9-4D2B-987F-82883E88E651;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;BE8B9AC4-DA93-47D7-B08E-1D79703713A3;0;0;1;Standard_DS2_v2
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;6B8597AE-6A6A-4857-AB9F-328A87DCCA5F;0;0;1;Standard_DS2_v2
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;CDB85C12-14CB-4A3C-AC7E-8670930B48F7;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;65C37A55-583F-4BE6-A3B4-FBDCC573845C;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;7A709776-91D9-4D2B-987F-82883E88E651;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;020BF601-4642-4909-AF27-263253BB148D;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;C3120C00-0AE2-4A6D-82B7-514E33AC8209;1;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;BE8B9AC4-DA93-47D7-B08E-1D79703713A3;0;0;1;Standard_DS2_v2
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;0B0637AB-7202-44C7-A93B-1DFD5D579474;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;56ACFFCF-DECF-4143-8372-193376B2FD75;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;C3120C00-0AE2-4A6D-82B7-514E33AC8209;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;29314E22-6DCC-463D-80CA-3B89E634A9DF;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;56ACFFCF-DECF-4143-8372-193376B2FD75;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;E532976B-89B4-4F6A-A308-C72BBBA66D5A;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;3C1E1CAB-ADF1-46B7-86FD-667B0A64FDE4;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;0B0637AB-7202-44C7-A93B-1DFD5D579474;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;08EA4409-2ED3-4091-BFE6-BAF42D5DC769;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;F6AEBC35-522E-49D6-AE5B-FCDDD1F4DF01;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;8F5D35B8-71CD-44B8-A003-31FFC741DB35;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;08EA4409-2ED3-4091-BFE6-BAF42D5DC769;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;7FC398A2-35E3-43C7-92D4-F9E3C92F0FBC;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;2B307D92-0594-40F4-ACB5-2F3181A2A567;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;2B307D92-0594-40F4-ACB5-2F3181A2A567;1;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;CA472C13-BF5D-47A3-B36D-07C9D376C650;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 1;7FC398A2-35E3-43C7-92D4-F9E3C92F0FBC;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;26EB0304-83E4-44F3-96D5-3A76EC3529C1;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;E7421856-4919-4FCC-9ADA-022CDC36F1ED;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;4710807C-FC91-44BA-965C-0FD8377CFA7E;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-16.04-xenial:4.15.0-1113-azure 0;020BF601-4642-4909-AF27-263253BB148D;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;0472B0FA-8CF5-48FB-AB90-BAD8D4F720F4;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 1;2966AE9D-5B86-4665-8107-8F4EBDEE3C01;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;A6549F3F-7073-468F-89E5-21AE1018E80B;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 1;F01D5D48-FAC3-4488-BB11-6AEDD88CFD19;1;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;1533D919-836E-4DEA-83A1-469483B0289A;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;3481345E-9B90-4024-ACFB-D653BF4BCC45;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;E4BD67A3-01BB-424C-9427-88030D0D048C;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 1;E4BD67A3-01BB-424C-9427-88030D0D048C;1;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 1;0472B0FA-8CF5-48FB-AB90-BAD8D4F720F4;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;B4101918-0138-45A1-950B-AC25B30083FD;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 1;2AE1FFB4-0794-49F6-9DAC-8FC71CB3002F;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;CF8C7FA3-B3BE-4AE0-9E10-933007A5379D;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;2AE1FFB4-0794-49F6-9DAC-8FC71CB3002F;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;2966AE9D-5B86-4665-8107-8F4EBDEE3C01;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;F01D5D48-FAC3-4488-BB11-6AEDD88CFD19;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-18.04-bionic:5.4.0-1067-azure 0;E4CD215E-EBFF-4715-B109-4E129909C6B5;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-20.04-focal:5.11.0-1027-azure 0;0D86A153-9751-4E32-9124-ABA22EE0115E;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-20.04-focal:5.11.0-1027-azure 1;3BB0477E-5E51-4D9C-8EEE-C95D99CBE748;1;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-20.04-focal:5.11.0-1027-azure 0;E94A583A-28D0-43F7-8C60-F9CEA4AA40D4;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-20.04-focal:5.11.0-1027-azure 1;E94A583A-28D0-43F7-8C60-F9CEA4AA40D4;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-20.04-focal:5.11.0-1027-azure 1;0D86A153-9751-4E32-9124-ABA22EE0115E;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-20.04-focal:5.11.0-1027-azure 1;FD19AAA0-1B16-457C-8DE2-3417C00126DB;0;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-20.04-focal:5.11.0-1027-azure 0;B7256E55-9F1D-449A-BE6B-92D877279555;1;0;1;Standard_D2s_v3
WALinuxAgent-9.9.9.9 Linux:ubuntu-20.04-focal:5.11.0-1027-azure 0;FD19AAA0-1B16-457C-8DE2-3417C00126DB;0;0;1;Standard_D2s_v3

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title of the PR mentions architecture, but this looks like size. Is this what was needed? Can you check that and edit the title if needed (and add a decription if possible)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure how much to put in the description, but I've updated the title to reflect the task (matching windows).

nagworld9
nagworld9 previously approved these changes Feb 2, 2022
View reviewed changes
@kevinclark19a kevinclark19a changed the title Report Architecture via Heartbeat telemetry event Report VMSize via Heartbeat telemetry event Feb 9, 2022
@kevinclark19a kevinclark19a merged commit 459f059 into Azure:develop Feb 9, 2022
@kevinclark19a kevinclark19a deleted the add_arch_to_heartbeat branch February 9, 2022 21:06
This was referenced Feb 16, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@larohra larohra larohra left review comments

@narrieta narrieta narrieta approved these changes

@nagworld9 nagworld9 nagworld9 approved these changes

@dhivyaganesan dhivyaganesan Awaiting requested review from dhivyaganesan

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

Assignees

@narrieta narrieta

@nagworld9 nagworld9

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevinclark19a @narrieta @larohra @nagworld9