Use handler status if extension status is None when computing the Ext… #2358

narrieta · 2021-09-17T22:06:26Z

If an extension doesn't have runtimeSettings, it's status won't have an extension status. In that case, we use the handler status instead.

…ensionsSummary

codecov · 2021-09-17T22:11:02Z

Codecov Report

Merging #2358 (baf38fd) into release-2.5.0.0 (0eeed5a) will increase coverage by 0.04%.
The diff coverage is 100.00%.

@@                 Coverage Diff                 @@
##           release-2.5.0.0    #2358      +/-   ##
===================================================
+ Coverage            70.87%   70.92%   +0.04%     
===================================================
  Files                   97       97              
  Lines                14110    14113       +3     
  Branches              2030     2030              
===================================================
+ Hits                 10001    10009       +8     
+ Misses                3662     3660       -2     
+ Partials               447      444       -3

Impacted Files	Coverage Δ
azurelinuxagent/ga/exthandlers.py	`86.32% <100.00%> (+0.03%)`	⬆️
azurelinuxagent/ga/update.py	`87.96% <100.00%> (ø)`
azurelinuxagent/ga/collect_telemetry_events.py	`91.43% <0.00%> (+1.71%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0eeed5a...baf38fd. Read the comment docs.

larohra · 2021-09-20T07:17:53Z

azurelinuxagent/ga/exthandlers.py

+    ready = "Ready"
+    not_ready = "NotReady"
+
+
 class ValidHandlerStatus(object):


NIT: HandlerStatus and ValidHandlerStatus sounds very confusing. Maybe change the name of this class to ExtensionStatus or ExtensionRuntimeStatus or something to make it more clearer?

Yes, but I plan to do that on a separate PR on develop. For now, i'm keeping it minimalistic for the release branch.

larohra · 2021-09-20T07:20:37Z

azurelinuxagent/ga/update.py

            self.summary.sort(key=lambda s: s[0])  # sort by extension name to make comparisons easier
-            self.converged = all(status in (ValidHandlerStatus.success, ValidHandlerStatus.error) for _, status in self.summary)
+            self.converged = all(status in (ValidHandlerStatus.success, ValidHandlerStatus.error, HandlerStatus.ready) for _, status in self.summary)


When looking at HandlerStatus, both Ready and NotReady imply that the Handler is Converged. They're just used to identify if the handler failed or not, but it still means that it converged. You should add HandlerStatus.not_ready here too

yes, good point

Azure#2358) * Use handler status if extension status is None when computing the ExtensionsSummary * Add NotReady to convergence statuses Co-authored-by: narrieta <narrieta>

Azure#2358) * Use handler status if extension status is None when computing the ExtensionsSummary * Add NotReady to convergence statuses Co-authored-by: narrieta <narrieta> (cherry picked from commit 81f7a1d)

#2358) (#2361) * Use handler status if extension status is None when computing the ExtensionsSummary * Add NotReady to convergence statuses Co-authored-by: narrieta <narrieta> (cherry picked from commit 81f7a1d) Co-authored-by: Norberto Arrieta <narrieta@users.noreply.github.com>

* release prepare-2.4.0.0 (#2280) * Fix bug with dependent extensions with no settings (#2285) * update test-requirements to pin pylint. (#2288) (#2299) Co-authored-by: Kevin Clark <kevin.clark@microsoft.com> * Do not create placeholder status file for AKS extensions (#2298) * Exception for Linux Patch Extension for creating placeholder status file (#2307) * update release version (#2308) * Dont create default status file for Single-Config extensions (#2318) * version update (#2319) * Update Version (#2348) * Fix bug with dependent extensions with no settings (#2285) (#2349) Co-authored-by: Laveesh Rohra <larohra@microsoft.com> * Use handler status if extension status is None when computing the Ext… (#2358) * Use handler status if extension status is None when computing the ExtensionsSummary * Add NotReady to convergence statuses Co-authored-by: narrieta <narrieta> * Release preparation 2.5.0.1 (#2360) * Define ExtensionsSummary.__eq__ (#2371) * define ExtensionsSummary.__eq__ * Fix test name * Fix test name * Fix test name Co-authored-by: narrieta <narrieta> * Release preparation 2.5.0.2 (#2372) * update cgroups monitoring expiry date (#2392) * Updated Agent Version to 2.6.0.0 (#2393) * Do not parse status blob (#2394) Co-authored-by: narrieta <narrieta> * Exclude dcr from setup (#2396) * Improve error message for vmSettings errors (#2397) * Improve error message for vmSettings errors * Add etag and correlation id * pylint warning Co-authored-by: narrieta <narrieta> * Updated agent version to 2.6.0.1 (#2400) * Verify that extensions goal state from vmsettings has been initialized (#2404) Co-authored-by: narrieta <narrieta> * Updated agent version to 2.6.0.2 (#2405) * Set Agent version to 2.7.0.0 (#2457) * Set Agent version to 2.7.0.0 * Remove duplicate import Co-authored-by: narrieta <narrieta> * Simplify the logic to update the extensions goal state (#2466) * Simplify the logic to update the extensions goal state * Added telemetry for NotSupported * Added comments * Do not support old hostgaplugin Co-authored-by: narrieta <narrieta> * Retry update_goal_state on GoalStateMismatchError (#2470) * Retry update_goal_state on GoalStateMismatchError * Add sleep before retry * Enable test * Enable test * Update test * Add unit test * Add data file * pylint warning * Add comment; fix typos * fix typo Co-authored-by: narrieta <narrieta> * Set agent version to 2.7.0.1 (#2473) * Redact settings from mismatch message (#2477) Co-authored-by: narrieta <narrieta> * Set Agent Version to 2.7.0.2 (#2478) Co-authored-by: narrieta <narrieta> * Improvements in telemetry for vmSettings (#2482) Co-authored-by: narrieta <narrieta> * Set Agent version to 2.7.0.3 (#2483) * Do not raise on missing status blob; reduce amount of logging for vms… (#2492) * Do not raise on missing status blob; reduce amount of logging for vmsettings * remove extra file; fix typo Co-authored-by: narrieta <narrieta> * Set agent version to 2.7.0.4 (#2494) Co-authored-by: narrieta <narrieta> * Save vmSettings on parse errors; improve messages in parse errors (#2503) * Save vmSettings on parse errors; improve messages in parse errors * pylint warnings * pylint warnings Co-authored-by: narrieta <narrieta> * Set agent version to 2.7.0.5 (#2504) Co-authored-by: narrieta <narrieta> * Revert "Set agent version to 2.7.0.5 (#2504)" (#2505) This reverts commit ae5a222. Co-authored-by: narrieta <narrieta> * ignore firewall packets reset error, check enable firewall config flag and extend cgroup extension monitoring expiry time (#2502) * Set agent version to 2.7.0.5 (#2506) Co-authored-by: narrieta <narrieta> * Handle OOM errors by stopping the periodic log collector (#2510) * Set agent version to 2.7.0.6 (#2511) * Add keep_alive property to collect_logs (#2533) * Set agent version to 2.7.1.0. (#2534) * Set agent version to 2.8.0.0 (#2545) Co-authored-by: narrieta <narrieta> * Update HGAP minimum required version for FastTrack (#2549) Co-authored-by: narrieta <narrieta> * Update agent version to 2.8.0.1 (#2550) Co-authored-by: narrieta <narrieta> * Improvements in waagent.log (#2558) * Improvements in waagent.log * fix function call * update comment * typo Co-authored-by: narrieta <narrieta> * Change format of history items (#2560) * Change format of history directory * Update message; fix typo * py2 compat * py2 compat Co-authored-by: narrieta <narrieta> * Update agent version to 2.8.0.2 (#2561) Co-authored-by: narrieta <narrieta> * Refresh goal state when certificates are missing (#2562) * Refresh goal state when certificates are missing * Improve error reporting * Fix assert message Co-authored-by: narrieta <narrieta> * Update agent version to 2.8.0.3 (#2563) Co-authored-by: narrieta <narrieta> * Do not mark goal state as processed when goal state fails to update (#2569) Co-authored-by: narrieta <narrieta> * Update agent version to 2.8.0.4 (#2570) Co-authored-by: narrieta <narrieta> * Bug fix for fetching a goal state with empty certificates property (#2575) * Move error counter reset down to end of block. (#2576) * Bug Fix: Change fast track timestamp default from None to datetime.min (#2577) * Update agent version to 2.8.0.5. (#2580) * Create placeholder GoalState.*.xml file (#2594) Co-authored-by: narrieta <narrieta> * Update version to 2.8.0.6 (#2595) Co-authored-by: narrieta <narrieta> * fix network interface restart in RHEL9 (#2592) (#2612) (cherry picked from commit b8ca432) * set agent version to 2.7.2.0 (#2613) * Parse missing agent manifests as empty * Set agent version to 2.8.0.7 * Retry HGAP's extensionsArtifact requests on BAD_REQUEST status (#2621) * Retry HGAP's extensionsArtifact requests on BAD_REQUEST status * python 2.6 compat Co-authored-by: narrieta <narrieta> * Retry HGAP's extensionsArtifact requests on BAD_REQUEST status (#2621) (#2622) * Retry HGAP's extensionsArtifact requests on BAD_REQUEST status * python 2.6 compat Co-authored-by: narrieta <narrieta> (cherry picked from commit dbc82d3) * fix if command in rhel v8.6+ (#2624) * Set agent version to 2.7.3.0 (#2625) Co-authored-by: narrieta <narrieta> * Set Agent version to 2.8.0.8 (#2627) Co-authored-by: narrieta <narrieta> * fix network interface restart in RHEL9 (#2592) (#2629) (cherry picked from commit b8ca432) Co-authored-by: Nageswara Nandigam <84482346+nagworld9@users.noreply.github.com> * fix if command in rhel v8.6+ (#2624) (#2630) (cherry picked from commit e540728) Co-authored-by: Nageswara Nandigam <84482346+nagworld9@users.noreply.github.com> * Set Agent version to 2.8.0.9 (#2631) Co-authored-by: narrieta <narrieta> * Cleanup history directory when creating new subdirectories (#2633) * Cleanup history directory when creating new subdirectories * Review feedback Co-authored-by: narrieta <narrieta> * Set agent version to 2.8.0.10 * Save sharedconfig to disk (#2649) * Save sharedconfig to disk * Update tests * pylint warnings Co-authored-by: narrieta <narrieta> * Set Agent version to 2.8.0.11 (#2650) Co-authored-by: narrieta <narrieta> * test fixes * Microsoft mandatory file (#2737) Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com> --------- Co-authored-by: Laveesh Rohra <larohra@microsoft.com> Co-authored-by: Kevin Clark <kevin.clark@microsoft.com> Co-authored-by: Norberto Arrieta <narrieta@users.noreply.github.com> Co-authored-by: Dhivya Ganesan <dhivyaganesan@users.noreply.github.com> Co-authored-by: narrieta <narrieta> Co-authored-by: Kevin Clark <keclar@microsoft.com> Co-authored-by: Norberto Arrieta <narrieta@microsoft.com> Co-authored-by: microsoft-github-policy-service[bot] <77245923+microsoft-github-policy-service[bot]@users.noreply.github.com>

Use handler status if extension status is None when computing the Ext…

482a762

…ensionsSummary

narrieta requested review from dhivyaganesan, kevinclark19a, larohra, nagworld9 and ZhidongPeng as code owners September 17, 2021 22:06

larohra reviewed Sep 20, 2021

View reviewed changes

Add NotReady to convergence statuses

baf38fd

larohra approved these changes Sep 20, 2021

View reviewed changes

dhivyaganesan approved these changes Sep 20, 2021

View reviewed changes

narrieta merged commit 81f7a1d into Azure:release-2.5.0.0 Sep 20, 2021

narrieta deleted the handler-status branch September 20, 2021 17:34

dhivyaganesan mentioned this pull request Sep 20, 2021

Use handler status if extension status is None when computing the Ext… #2361

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use handler status if extension status is None when computing the Ext… #2358

Use handler status if extension status is None when computing the Ext… #2358

narrieta commented Sep 17, 2021

codecov bot commented Sep 17, 2021 •

edited

Loading

larohra Sep 20, 2021

narrieta Sep 20, 2021

larohra Sep 20, 2021

narrieta Sep 20, 2021

Use handler status if extension status is None when computing the Ext… #2358

Use handler status if extension status is None when computing the Ext… #2358

Conversation

narrieta commented Sep 17, 2021

codecov bot commented Sep 17, 2021 • edited Loading

Codecov Report

larohra Sep 20, 2021

Choose a reason for hiding this comment

narrieta Sep 20, 2021

Choose a reason for hiding this comment

larohra Sep 20, 2021

Choose a reason for hiding this comment

narrieta Sep 20, 2021

Choose a reason for hiding this comment

codecov bot commented Sep 17, 2021 •

edited

Loading