Save the original subprocess.Popen before mocking it #2340
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
dhivyaganesan,
kevinclark19a,
larohra,
nagworld9 and
ZhidongPeng
as code owners
narrieta
commented
Aug 24, 2021
| @@ -1105,7 +1107,7 @@ def _test_run_latest(self, mock_child=None, mock_time=None, child_args=None): | |||
| if mock_time is None: | |||
| mock_time = TimeMock() | |||
|
|
|||
| with patch('subprocess.Popen', return_value=mock_child) as mock_popen: | |||
| with patch('azurelinuxagent.ga.update.subprocess.Popen', return_value=mock_child) as mock_popen: | |||
There was a problem hiding this comment.
this doesn't change the behavior of the tests, but is more explicit as to what we intent to mock
Codecov Report
@@ Coverage Diff @@
## develop #2340 +/- ##
===========================================
+ Coverage 70.86% 70.90% +0.03%
===========================================
Files 97 97
Lines 14105 14105
Branches 2029 2029
===========================================
+ Hits 9996 10001 +5
+ Misses 3662 3660 -2
+ Partials 447 444 -3
Continue to review full report at Codecov.
|
larohra
approved these changes
Aug 25, 2021
kevinclark19a
approved these changes
Aug 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The firewalll tests need the value of subprocess.Popen before other tests mock it (in case those tests run in parallel)