-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report transitioning when status file not found #2330
Conversation
Codecov Report
@@ Coverage Diff @@
## develop #2330 +/- ##
===========================================
- Coverage 70.79% 70.78% -0.02%
===========================================
Files 97 97
Lines 14029 14034 +5
Branches 2012 2013 +1
===========================================
+ Hits 9932 9934 +2
- Misses 3656 3657 +1
- Partials 441 443 +2
Continue to review full report at Codecov.
|
# A fix will follow soon where we will report transitioning status for extensions by default if no status file | ||
# found instead of reporting an error. | ||
if ext_handler_i.should_perform_multi_config_op(extension): | ||
ext_handler_i.create_placeholder_status_file(extension) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see that we still have 3 calls to create_placeholder_status_file to create the status file on some error conditions.
Should we rename this function to avoid confusion with the placeholder file mentioned in the publisher's spec, and also remove the default values for the parameters, which seem to be targeted to this one call that you are removing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure let me send an update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the updates!
Description
Extensions can take up some time to write status file. If the Agent does not find a status file for the extension, then we report an error back to CRP which fails the operation. In order to avoid doing that and to give extensions enough time to write status files, we'll report a transitioning status back to CRP with a clear cut message stating that the status was reported by the Guest Agent due to missing status file.
Issue #
PR information
Quality of Code and Contribution Guidelines