Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding the new file to log collector #2301

Merged
merged 4 commits into from
Jul 13, 2021

Conversation

dhivyaganesan
Copy link
Contributor

The new file will be of format "waagent_status.0.json"

Description

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made

Quality of Code and Contribution Guidelines

@@ -55,6 +55,7 @@
os.path.join(_AGENT_LIB_DIR, "SharedConfig.*.xml"),
os.path.join(_AGENT_LIB_DIR, "*manifest.xml"),
os.path.join(_AGENT_LIB_DIR, "waagent_status.json"),
os.path.join(_AGENT_LIB_DIR, "waagent_status.*.json"),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in this case we can remove the old file

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks , Updated the PR

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #2301 (e288d6d) into develop (fe1f088) will increase coverage by 0.02%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #2301      +/-   ##
===========================================
+ Coverage    70.72%   70.74%   +0.02%     
===========================================
  Files           96       96              
  Lines        13959    13959              
  Branches      2000     2000              
===========================================
+ Hits          9872     9875       +3     
+ Misses        3649     3646       -3     
  Partials       438      438              
Impacted Files Coverage Δ
azurelinuxagent/common/logcollector.py 88.78% <ø> (ø)
azurelinuxagent/common/logcollector_manifests.py 100.00% <ø> (ø)
azurelinuxagent/common/event.py 85.90% <0.00%> (+0.68%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe1f088...e288d6d. Read the comment docs.

@dhivyaganesan dhivyaganesan merged commit b160c23 into Azure:develop Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants