-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed bug causing "MAC verified OK" message #2069
Merged
kevinclark19a
merged 42 commits into
Azure:develop
from
kevinclark19a:SwitchToRunCommand
Nov 5, 2020
Merged
Fixed bug causing "MAC verified OK" message #2069
kevinclark19a
merged 42 commits into
Azure:develop
from
kevinclark19a:SwitchToRunCommand
Nov 5, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… everything that needs changing.
…Agent into SwitchToRunCommand
…Agent into SwitchToRunCommand
This reverts commit f90227f.
kevinclark19a
requested review from
larohra,
narrieta,
pgombar and
ZhidongPeng
as code owners
November 5, 2020 18:09
larohra
reviewed
Nov 5, 2020
larohra
approved these changes
Nov 5, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 small question else LGTM
pgombar
approved these changes
Nov 5, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A bug in older versions of openssl was causing the message "MAC verified OK" to be sent out on stderr during the processing of every goal state in the agent. Before PR #2050, the agent would suppress the stderr output. This PR adds that suppression back.
PR information
Quality of Code and Contribution Guidelines