-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SUSE config: use Btrfs LZO compression for ResourceDisk #2055
Conversation
1bf7a1a
to
5f40dad
Compare
@rjschwei please review |
Thanks a lot for the review, Robert. |
@trstringer could you take a look? thanks! |
Something to consider is that the SUSE images using cloud-init as the provisioning agent seem to be using ext4. Here's the resource disk of the
So users going from walinuxagent -> cloud-init would introduce a change from btrfs -> ext4 now with this PR. This is not necessarily a blocking issue for me, but let me know your thoughts on that change, @rjschwei. |
@trstringer yes, we switched all images to use cloud-init per customer requests and downstream work for image build setup is required. This change is for those that pull the agent directly from GitHub or build custom images that use the agent package we (SUSE) provides and do not use cloud-init. |
@rjschwei, ok that makes sense. So if you're fine with the different resource disk filesystems between waagent and cloud-init for SUSE images, that works for me. |
running automation |
Automation OK |
@ddiss - could you bring your branch up to date with develop? thanks! |
Btrfs provides support for transparent compression, which can be requested at mount time via the compress=type[:level] mount option. As demonstrated in [1], transparent LZO compression provides a good trade-off between compression ratio and performance, while also being supported by legacy SUSE kernels. zstd could be considered for modern SLE15-SP1+ / openSUSE Leap 15.1+ kernels. Amongst other benefits, moving from ext4 to Btrfs allows for ephemeral ResourceDisk data to be periodically and incrementally backed-up to regular Page Blob backed disks using btrfs send/recv. 1. Btrfs compression benchmarks mainline kernel commit: 5c1aab1dd5445ed8bdcdbb575abc1b0d7ee5b2e7 Signed-off-by: David Disseldorp <ddiss@suse.de>
655ed08
5f40dad
to
655ed08
Compare
Done, thanks |
Btrfs provides support for transparent compression, which can be
requested at mount time via the compress=type[:level] mount option.
As demonstrated in [1], transparent LZO compression provides a good
trade-off between compression ratio and performance, while also being
supported by legacy SUSE kernels. zstd could be considered for
modern SLE15-SP1+ / openSUSE Leap 15.1+ kernels.
Amongst other benefits, moving from ext4 to Btrfs allows for ephemeral
ResourceDisk data to be periodically and incrementally backed-up to
regular Page Blob backed disks using btrfs send/recv.
mainline kernel commit: 5c1aab1dd5445ed8bdcdbb575abc1b0d7ee5b2e7
Signed-off-by: David Disseldorp ddiss@suse.de
Description
Issue #
PR information
Quality of Code and Contribution Guidelines