Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix timestamp for goal state archive #2051

Merged
merged 13 commits into from
Nov 4, 2020
Merged

Fix timestamp for goal state archive #2051

merged 13 commits into from
Nov 4, 2020

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Oct 23, 2020

Description

Today, we archive the last processed goal state when a new goal state comes in. However, we erroneously use the new goal state timestamp for that archive instead of when we received the last processed goal state. This PR fixed the archive timestamp.

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@pgombar pgombar requested a review from narrieta October 23, 2020 22:37
kevinclark19a
kevinclark19a previously approved these changes Oct 28, 2020
View reviewed changes
larohra
larohra reviewed Oct 28, 2020
View reviewed changes
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
azurelinuxagent/common/utils/archive.py Outdated Show resolved Hide resolved
larohra
larohra reviewed Oct 30, 2020
View reviewed changes
Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some small comments

@pgombar pgombar requested a review from larohra October 30, 2020 00:54
larohra
larohra previously approved these changes Oct 30, 2020
View reviewed changes
@pgombar pgombar added this to the v2.2.53 milestone Nov 3, 2020
@pgombar pgombar merged commit 9385e56 into Azure:develop Nov 4, 2020
@pgombar pgombar deleted the fix_archive_timestamp branch November 4, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narrieta narrieta narrieta approved these changes

@larohra larohra larohra approved these changes

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

@kevinclark19a kevinclark19a Awaiting requested review from kevinclark19a

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.53
Development

Successfully merging this pull request may close these issues.
4 participants
@pgombar @narrieta @kevinclark19a @larohra