Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Limit description character length sent for health report #2020

Merged
merged 5 commits into from
Sep 28, 2020
Merged

Limit description character length sent for health report #2020

merged 5 commits into from
Sep 28, 2020

Conversation

trstringer
Copy link
Contributor

Description

This PR limits the description length that can be sent for a health report. The platform supports a maximum of 4096 characters for the description text.

E.g. <Description>this text can only be a max of 4096 characters</Description>

Issue #2017

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@trstringer trstringer changed the title Thstring/health desc limit Limit description character length sent for health report Sep 23, 2020
@narrieta
Copy link
Member

code looks good; running automation

@trstringer
Copy link
Contributor Author

Thanks, @narrieta!

@larohra larohra merged commit b8d5c35 into Azure:develop Sep 28, 2020
@trstringer trstringer mentioned this pull request Sep 29, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnsonshi johnsonshi johnsonshi left review comments

@narrieta narrieta narrieta approved these changes

@larohra larohra larohra approved these changes

@kevinclark19a kevinclark19a Awaiting requested review from kevinclark19a

@pgombar pgombar Awaiting requested review from pgombar

@ZhidongPeng ZhidongPeng Awaiting requested review from ZhidongPeng ZhidongPeng is a code owner

@anhvoms anhvoms Awaiting requested review from anhvoms

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@trstringer @narrieta @johnsonshi @larohra