Verify that the extension status is an array #2010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
narrieta
requested review from
kevinclark19a,
larohra,
pgombar and
ZhidongPeng
as code owners
larohra
reviewed
Sep 15, 2020
azurelinuxagent/ga/exthandlers.py
Outdated
| return | ||
| if not isinstance(data, list): | ||
| raise ExtensionStatusError(msg="The extension status must be an array: {0}".format(data), code=ExtensionStatusError.StatusFileMalformed) |
There was a problem hiding this comment.
Data would contain the complete content of the status file, wont that be too verbose if the extension status is huge (multiple substatuses, etc)?
There was a problem hiding this comment.
Yes, I thought about truncating it, but I really want to capture the extension name if it is there. The verbosity wouldn't matter too much, I think. I can always truncate it to 1 or 2 K.
There was a problem hiding this comment.
actually, the error message also goes to telemetry... let me check if we truncate or if a large message would drop the event
There was a problem hiding this comment.
yes, greater that 64512 we would drop the event. i'll truncate at 4K
kevinclark19a
previously approved these changes
Sep 15, 2020
larohra
approved these changes
Sep 16, 2020
kevinclark19a
approved these changes
Sep 16, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the status for one extension is not an array, the agent fails to report status for all extensions