Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformatted the heartbeat event #2009

Merged
merged 1 commit into from
Sep 15, 2020

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Sep 11, 2020

Description

Earlier we were always resetting the UpdateGSErrors In the heartbeat message before writing the message due to which the debug_log_message always had the wrong heartbeatId and UpdateGSErrors == 0 (the Kusto event was fine though).

This PR fixed this issue by ensuring that we always write the logs first and then update/reset the counters.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@larohra larohra merged commit 13d8ce4 into Azure:develop Sep 15, 2020
@larohra larohra deleted the fix-heartbeat-gs-counter branch September 15, 2020 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants