Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixing Linter errors: duplicate-key<W0109>. #2002

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Fixing Linter errors: duplicate-key<W0109>. #2002

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6cf6ca4
Removed single duplicate key.
Sep 4, 2020
d9b168b
Merge branch 'develop' into LinterDuplicateKey
kevinclark19a Sep 9, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion ci/2.7.pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@
# cell-var-from-loop<W0640>: (hi-pri) A variable used in a closure is defined in a loop. This will result in all closures using the same value for the closed-over variable.
# cyclic-import<R0401>: (hi-pri) Used when a cyclic import between two or more modules is detected.
# dangerous-default-value<W0102>: (hi-pri) Used when a mutable value as list or dictionary is detected in a default value for an argument.
# duplicate-key<W0109>: (hi-pri) Used when a dictionary expression binds the same key multiple times.
# expression-not-assigned<W0106>: (hi-pri) Used when an expression that is not a function call is assigned to nothing.
# duplicate-code<R0801>: (hi-pri) Indicates that a set of similar lines has been detected among multiple file. (also disabled globally)
# fixme<W0511>: Used when a warning note as FIXME or TODO is detected
Expand Down
1 change: 0 additions & 1 deletion ci/3.6.pylintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
# consider-using-in<R1714>: To check if a variable is equal to one of many values,combine the values into a tuple and check if the variable is contained "in" it instead of checking for equality against each of the values.
# cyclic-import<R0401>: (hi-pri) Used when a cyclic import between two or more modules is detected.
# dangerous-default-value<W0102>: (hi-pri) Used when a mutable value as list or dictionary is detected in a default value for an argument.
# duplicate-key<W0109>: (hi-pri) Used when a dictionary expression binds the same key multiple times.
# duplicate-code<R0801>: (hi-pri) Indicates that a set of similar lines has been detected among multiple file. (also disabled globally)
# duplicate-string-formatting-argument<W1308>: (hi-pri) Used when we detect that a string formatting is repeating an argument instead of using named string arguments
# expression-not-assigned<W0106>: (hi-pri) Used when an expression that is not a function call is assigned to nothing.
Expand Down
8 changes: 1 addition & 7 deletions tests/utils/test_flexible_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ def test_compile_pattern(self): # pylint: disable=useless-return
def test_compile_pattern_sep(self): # pylint: disable=useless-return
self.v.sep = '-'
self.v._compile_pattern() # pylint: disable=protected-access
tests = { # pylint: disable=duplicate-key
tests = {
'1': True,
'1-2': True,
'1-2-3': True,
Expand All @@ -97,10 +97,8 @@ def test_compile_pattern_sep(self): # pylint: disable=useless-return

'1alpha': True,
'1-alpha': True,
'1-alpha': True,
'1alpha0': True,
'1-alpha0': True,
'1-alpha0': True,
'1-2alpha': True,
'1-2.alpha': True,
'1-2-alpha': True,
Expand All @@ -110,10 +108,8 @@ def test_compile_pattern_sep(self): # pylint: disable=useless-return

'1beta': True,
'1-beta': True,
'1-beta': True,
'1beta0': True,
'1-beta0': True,
'1-beta0': True,
'1-2beta': True,
'1-2.beta': True,
'1-2-beta': True,
Expand All @@ -123,10 +119,8 @@ def test_compile_pattern_sep(self): # pylint: disable=useless-return

'1rc': True,
'1-rc': True,
'1-rc': True,
'1rc0': True,
'1-rc0': True,
'1-rc0': True,
'1-2rc': True,
'1-2.rc': True,
'1-2-rc': True,
Expand Down