Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabled linter for azurelinuxagent.pa. #1981

Merged
merged 7 commits into from
Aug 21, 2020

Conversation

kevinclark19a
Copy link
Contributor

@kevinclark19a kevinclark19a commented Aug 11, 2020

Description

7th of 7 PRs enabling linter in Travis.

Error Codes can be found here: http://pylint.pycqa.org/en/latest/technical_reference/features.html


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Aug 11, 2020

Codecov Report

Merging #1981 into develop will increase coverage by 0.01%.
The diff coverage is 54.54%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1981      +/-   ##
===========================================
+ Coverage    71.13%   71.15%   +0.01%     
===========================================
  Files           86       86              
  Lines        12286    12285       -1     
  Branches      1730     1729       -1     
===========================================
+ Hits          8740     8741       +1     
+ Misses        3160     3159       -1     
+ Partials       386      385       -1     
Impacted Files Coverage Δ
azurelinuxagent/pa/rdma/centos.py 24.48% <25.00%> (ø)
azurelinuxagent/pa/rdma/ubuntu.py 13.92% <27.27%> (ø)
azurelinuxagent/pa/provision/default.py 74.11% <45.45%> (ø)
azurelinuxagent/pa/deprovision/factory.py 57.89% <50.00%> (ø)
azurelinuxagent/pa/rdma/factory.py 56.25% <50.00%> (ø)
azurelinuxagent/pa/rdma/suse.py 4.95% <50.00%> (ø)
azurelinuxagent/pa/provision/cloudinit.py 58.06% <71.42%> (ø)
azurelinuxagent/pa/deprovision/default.py 67.85% <73.33%> (ø)
azurelinuxagent/pa/deprovision/arch.py 45.45% <100.00%> (ø)
azurelinuxagent/pa/deprovision/clearlinux.py 62.50% <100.00%> (ø)
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 09bed7b...8d0035e. Read the comment docs.

Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, not approving before the pylintrc files are updated.

pgombar
pgombar previously approved these changes Aug 17, 2020
narrieta
narrieta previously approved these changes Aug 19, 2020
narrieta
narrieta previously approved these changes Aug 21, 2020
narrieta
narrieta previously approved these changes Aug 21, 2020
@kevinclark19a kevinclark19a merged commit d20a337 into Azure:develop Aug 21, 2020
@kevinclark19a kevinclark19a deleted the LinterEnabledPa branch August 21, 2020 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants