Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move AutoUpdate reporting to HeartBeat event #1919

Merged
merged 6 commits into from
Jun 26, 2020

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Jun 25, 2020

Description

  1. AutoUpdate needs to be reported more frequently than just on system startup (Emit AutoUpdate value at service start only #1907) in order to know how many VMs in our fleet are not updating due to potential issues or due to AutoUpdate being set to false.
  2. Move AutoUpdate reporting to HeartBeat event which is emitted and logged locally every half an hour.
  3. Emit HeartBeat in the beginning of the exthandlers thread.

Local log message:
2020-06-25T21:01:19.140669Z INFO ExtHandler ExtHandler [HEARTBEAT] Agent WALinuxAgent-2.2.48.1 is running as the goal state agent [DEBUG HeartbeatCounter: 1;HeartbeatId: BC244091-DA90-476D-A49D-6184F6A4125D;DroppedPackets: 0;UpdateGSErrors: 0;AutoUpdate: 1]


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jun 25, 2020

Codecov Report

Merging #1919 into release-2.2.49 will decrease coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@                Coverage Diff                 @@
##           release-2.2.49    #1919      +/-   ##
==================================================
- Coverage           69.47%   69.46%   -0.02%     
==================================================
  Files                  85       85              
  Lines               11870    11867       -3     
  Branches             1667     1667              
==================================================
- Hits                 8247     8243       -4     
- Misses               3252     3253       +1     
  Partials              371      371              
Impacted Files Coverage Δ
azurelinuxagent/common/event.py 85.93% <ø> (-0.04%) ⬇️
azurelinuxagent/ga/update.py 87.59% <100.00%> (-0.20%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9f3dca0...01bd5f7. Read the comment docs.

larohra
larohra previously approved these changes Jun 26, 2020
Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 minor comment everything else LGTM

azurelinuxagent/ga/update.py Outdated Show resolved Hide resolved
Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgombar pgombar merged commit 7c33c78 into Azure:release-2.2.49 Jun 26, 2020
@pgombar pgombar deleted the hotfix_autoupdate branch June 26, 2020 17:41
pgombar added a commit to pgombar/WALinuxAgent that referenced this pull request Jun 26, 2020
pgombar added a commit to pgombar/WALinuxAgent that referenced this pull request Jun 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants