Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up import statements #1900

Merged
merged 2 commits into from
Jun 3, 2020
Merged

Clean up import statements #1900

merged 2 commits into from
Jun 3, 2020

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Jun 2, 2020

Description

Unpack import * and clean up imports (sort alphabetically, remove unused).


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

larohra
larohra previously approved these changes Jun 2, 2020
Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this change, our small step towards a cleaner healthier code :)
Just make sure to get a greeen DCR run before merging :)

@codecov
Copy link

codecov bot commented Jun 2, 2020

Codecov Report

Merging #1900 into develop will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1900   +/-   ##
========================================
  Coverage    69.42%   69.42%           
========================================
  Files           85       85           
  Lines        11788    11789    +1     
  Branches      1653     1653           
========================================
+ Hits          8184     8185    +1     
  Misses        3239     3239           
  Partials       365      365           
Impacted Files Coverage Δ
azurelinuxagent/common/osutil/factory.py 97.29% <100.00%> (ø)
azurelinuxagent/common/protocol/goal_state.py 93.81% <100.00%> (+0.02%) ⬆️
azurelinuxagent/common/protocol/wire.py 77.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c881efb...349a3f5. Read the comment docs.

@pgombar pgombar merged commit d68dd3b into Azure:develop Jun 3, 2020
@pgombar pgombar deleted the fix_imports branch June 3, 2020 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants