-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the cleanup-outdated-handlers to only delete handlers that are not present in the GS #1889
Fix the cleanup-outdated-handlers to only delete handlers that are not present in the GS #1889
Conversation
…to only use public methods to eventually replace the current cleanup test class
… GS based on name
Codecov Report
@@ Coverage Diff @@
## develop #1889 +/- ##
===========================================
+ Coverage 69.20% 69.44% +0.24%
===========================================
Files 83 83
Lines 11445 11445
Branches 1589 1590 +1
===========================================
+ Hits 7920 7948 +28
+ Misses 3202 3166 -36
- Partials 323 331 +8
Continue to review full report at Codecov.
|
…' into report-install-failures-properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comments, thanks for this change!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added some minor comments
…derlying PUT call
Description
This PR focuses on fixing the cleanup-outdated-handlers functions to only delete handlers that are not present in the GS rather than cleaning up all the Extension Handlers with State==NotInstalled.
This PR addresses 1st part of the issue where the LinuxAgent does not report install failures properly back to CRP which leads to a bad customer experience.
Issue #
PR information
Quality of Code and Contribution Guidelines