Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the cleanup-outdated-handlers to only delete handlers that are not present in the GS #1889

Merged
merged 10 commits into from
May 21, 2020

Conversation

larohra
Copy link
Contributor

@larohra larohra commented May 18, 2020

Description

This PR focuses on fixing the cleanup-outdated-handlers functions to only delete handlers that are not present in the GS rather than cleaning up all the Extension Handlers with State==NotInstalled.

This PR addresses 1st part of the issue where the LinuxAgent does not report install failures properly back to CRP which leads to a bad customer experience.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented May 18, 2020

Codecov Report

Merging #1889 into develop will increase coverage by 0.24%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1889      +/-   ##
===========================================
+ Coverage    69.20%   69.44%   +0.24%     
===========================================
  Files           83       83              
  Lines        11445    11445              
  Branches      1589     1590       +1     
===========================================
+ Hits          7920     7948      +28     
+ Misses        3202     3166      -36     
- Partials       323      331       +8     
Impacted Files Coverage Δ
azurelinuxagent/ga/exthandlers.py 87.53% <100.00%> (-0.69%) ⬇️
azurelinuxagent/pa/provision/default.py 74.24% <0.00%> (-1.02%) ⬇️
azurelinuxagent/common/protocol/wire.py 77.00% <0.00%> (+4.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1268fdc...3ae544b. Read the comment docs.

pgombar
pgombar previously approved these changes May 19, 2020
Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, thanks for this change!

azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
tests/ga/test_extension.py Outdated Show resolved Hide resolved
tests/ga/test_extension.py Outdated Show resolved Hide resolved
pgombar
pgombar previously approved these changes May 21, 2020
Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added some minor comments

@larohra larohra merged commit ea6df52 into Azure:develop May 21, 2020
@larohra larohra deleted the report-install-failures-properly branch May 21, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants