Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade unit test to be compatible with Python 3.8 #1860

Merged
merged 7 commits into from
Apr 23, 2020

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Apr 21, 2020

Description

  • Fixed tests that were failing in Python 3.8
  • Removed coverage output in Travis runs since the output was getting in the way of readability for unit test runs (codecov still runs on PRs and commits)
  • Disabled tests that rely on mocking platform.dist. These tests and the method they are testing need to be updated once we figure out a good strategy to support distro and get away from platform.

Related to #1859.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left some comments

tests/common/test_version.py Outdated Show resolved Hide resolved
test-requirements.txt Outdated Show resolved Hide resolved
tests/common/test_version.py Outdated Show resolved Hide resolved
@larohra
Copy link
Contributor

larohra commented Apr 22, 2020

Removed coverage output in Travis runs since the output was getting in the way of readability for unit test runs (codecov still runs on PRs and commits)

Thanks for removing coverage, it was definitely annoying to see the red cross even when Travis passed! That being said, I dont see the codecov results for in the PR anywhere. Is there a specific place I need to look for it?

@pgombar
Copy link
Contributor Author

pgombar commented Apr 22, 2020

Removed coverage output in Travis runs since the output was getting in the way of readability for unit test runs (codecov still runs on PRs and commits)

Thanks for removing coverage, it was definitely annoying to see the red cross even when Travis passed! That being said, I dont see the codecov results for in the PR anywhere. Is there a specific place I need to look for it?

No, you're definitely right, by removing it from the yaml file, it removes the hook to run on each commit. I will revert the change then, I don't think there's a way where we can remove the output from individual Travis runs but still keep a hook on GitHub.

Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pgombar pgombar merged commit f08dd83 into Azure:develop Apr 23, 2020
@pgombar pgombar deleted the test_py38 branch April 23, 2020 22:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants