-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade unit test to be compatible with Python 3.8 #1860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments
Thanks for removing coverage, it was definitely annoying to see the red cross even when Travis passed! That being said, I dont see the codecov results for in the PR anywhere. Is there a specific place I need to look for it? |
No, you're definitely right, by removing it from the yaml file, it removes the hook to run on each commit. I will revert the change then, I don't think there's a way where we can remove the output from individual Travis runs but still keep a hook on GitHub. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
platform.dist
. These tests and the method they are testing need to be updated once we figure out a good strategy to supportdistro
and get away fromplatform
.Related to #1859.
PR information
Quality of Code and Contribution Guidelines