Update 'Provisioning' options in default configs #1853
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vittyvk
requested review from
larohra,
narrieta,
pgombar,
vrdmr and
ZhidongPeng
as code owners
Codecov Report
@@ Coverage Diff @@
## develop #1853 +/- ##
===========================================
- Coverage 69.47% 69.45% -0.02%
===========================================
Files 82 82
Lines 11469 11469
Branches 1619 1619
===========================================
- Hits 7968 7966 -2
- Misses 3164 3166 +2
Partials 337 337
Continue to review full report at Codecov.
|
'Provisioning.Enabled' and 'Provisioning.UseCloudInit' parameters are removed since v2.2.45 and replaced with 'Provisioning.Agent'. Update distro specific configs accordingly. Signed-off-by: Vitaly Kuznetsov <vkuznets@redhat.com>
vittyvk
force-pushed
the
waagent_prov_conf
branch
from
f29e9e7
to
7c3f8c8
Compare
narrieta
requested review from
trstringer
and removed request for
vrdmr,
trstringer,
ZhidongPeng,
narrieta,
pgombar and
larohra
trstringer
approved these changes
Apr 15, 2020
narrieta
approved these changes
Apr 15, 2020
|
@vittyvk - it seems like you need to update your branch with develop. thanks! |
|
The commit doesn't change the code so I hope the 0.02% change in coverage can be tolerated. |
narrieta
approved these changes
Apr 20, 2020
pgombar
approved these changes
Apr 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
'Provisioning.Enabled' and 'Provisioning.UseCloudInit' parameters are
removed since v2.2.45 and replaced with 'Provisioning.Agent'. Update
distro specific configs accordingly.
Issue #
PR information
Quality of Code and Contribution Guidelines
This change is