Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit test to verify call stacks on telemetry events #1828

Merged
merged 4 commits into from
Mar 20, 2020

Conversation

narrieta
Copy link
Member

@narrieta narrieta commented Mar 20, 2020

While the issue in the telemetry events that include call stacks seems to be external to the agent, I am adding a test to verify that the Message of the event we send in the HTTP request matches the Message we read from the *.tld file.

The test *.tld file does repro the issue on Kusto.


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 20, 2020

Codecov Report

Merging #1828 into develop will not change coverage by %.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1828   +/-   ##
========================================
  Coverage    69.04%   69.04%           
========================================
  Files           82       82           
  Lines        11834    11834           
  Branches      1656     1656           
========================================
  Hits          8171     8171           
  Misses        3314     3314           
  Partials       349      349           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 61221d6...a3a2f5b. Read the comment docs.

Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this test! LGTM

@narrieta narrieta merged commit a546502 into Azure:develop Mar 20, 2020
@narrieta narrieta deleted the event-call-stack branch March 24, 2020 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants