Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add lock around protocol detection #1816

Merged
merged 1 commit into from
Mar 17, 2020
Merged

Add lock around protocol detection #1816

merged 1 commit into from
Mar 17, 2020

Conversation

narrieta
Copy link
Member

@narrieta narrieta commented Mar 17, 2020 •
edited by vrdmr
Loading

Replaces #1815 (adding change to release-2.2.47)

This change is Reviewable

@narrieta narrieta mentioned this pull request Mar 17, 2020
Closed
@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release-2.2.47@2eec112). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.2.47    #1816   +/-   ##
=================================================
  Coverage                  ?   68.57%           
=================================================
  Files                     ?       82           
  Lines                     ?    11739           
  Branches                  ?     1644           
=================================================
  Hits                      ?     8050           
  Misses                    ?     3343           
  Partials                  ?      346

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2eec112...9be94f2. Read the comment docs.

@narrieta narrieta merged commit f050ec9 into Azure:release-2.2.47 Mar 17, 2020
vrdmr added a commit that referenced this pull request Mar 18, 2020
@vrdmr
Merging Release 2.2.47 into Develop (#1825)
3a3b19f 
* Add lock around protocol detection (#1816)
* Reduce the verbosity of goal state errors (#1820)
* Fix telemetry events for fetch goal state
* Added unit test
* Improved error messages
* Version update to 2.2.47.1 (#1824)
Co-authored-by: Norberto Arrieta <narrieta@users.noreply.github.com>
@narrieta narrieta deleted the protocol branch March 20, 2020 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrdmr vrdmr vrdmr approved these changes

@pgombar pgombar pgombar approved these changes

@larohra larohra Awaiting requested review from larohra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narrieta @vrdmr @pgombar