Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch goal state when creating HostPluginProtocol #1799

Merged
merged 2 commits into from
Mar 5, 2020

Conversation

narrieta
Copy link
Member

@narrieta narrieta commented Mar 5, 2020

Now we fetch the goal state explicitly instead of relying on somebody else initializing the instance in WireClient.

Also, the GoalState instance in WireClient will be removed as part of the next round of refactoring of the Protocol interface.


This change is Reviewable

@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #1799 into develop will decrease coverage by 0.39%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1799      +/-   ##
===========================================
- Coverage    68.88%   68.49%   -0.40%     
===========================================
  Files           81       82       +1     
  Lines        11374    11734     +360     
  Branches      1603     1644      +41     
===========================================
+ Hits          7835     8037     +202     
- Misses        3207     3349     +142     
- Partials       332      348      +16     
Impacted Files Coverage Δ
azurelinuxagent/common/protocol/wire.py 70.52% <0.00%> (-1.35%) ⬇️
azurelinuxagent/common/protocol/hostplugin.py 83.60% <0.00%> (-0.55%) ⬇️
azurelinuxagent/common/protocol/metadata.py 53.31% <0.00%> (ø)
azurelinuxagent/common/utils/restutil.py 91.47% <0.00%> (+0.38%) ⬆️
azurelinuxagent/common/protocol/restapi.py 87.42% <0.00%> (+0.59%) ⬆️
azurelinuxagent/common/protocol/goal_state.py 94.13% <0.00%> (ø)
azurelinuxagent/common/utils/cryptutil.py 50.00% <0.00%> (+1.92%) ⬆️
azurelinuxagent/common/protocol/util.py 83.41% <0.00%> (+3.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7309ffd...9ce2098. Read the comment docs.

@narrieta narrieta merged commit f917863 into Azure:develop Mar 5, 2020
@narrieta narrieta deleted the plugin branch March 5, 2020 23:31
@narrieta narrieta mentioned this pull request Mar 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants