Enable SWAP on Resource Disk as Application Certification Support suggested

[lwhsu]

…gested

Description

Issue #
The FreeBSD image on Azure used to have a swap partition allocated, as Application Certification Support suggested, moving it to Resource Disk is the better choice.

---

PR information

• The title of the PR is clear and informative.
• There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
• Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
• If applicable, the PR references the bug/issue that it fixes in the description.
• New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

• I have read the contribution guidelines.

---

This change is 

[codecov]

Codecov Report

Merging #1762 into develop will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           develop    #1762   +/-   ##
========================================
  Coverage    69.15%   69.15%           
========================================
  Files           82       82           
  Lines        11711    11711           
  Branches      1642     1642           
========================================
  Hits          8099     8099           
  Misses        3261     3261           
  Partials       351      351

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c7658...14236c2. Read the comment docs.

[vrdmr]

@trstringer: Can you please review the change? Thanks.

[lwhsu]

Any updates on this? BTW, I'm working with with @whu2014 to provide official FreeBSD image on Azure.

[lwhsu]

Any update of this?

[lwhsu]

ping?

[trstringer]

Thanks for opening up this PR! This seems to be a configuration change, why not just make this change in your custom image? It's a thing we should carefully consider to change the defaults for all users, and this seems like an easy one to bake into your own custom image.

[lwhsu]

Thanks for your reply. Yes I have a local modification of azure-agent package on FreeBSD for building image for now. And I want to upstream this change because of the spirit of open source community. Please note that the FreeBSD image we are going to build is for Official FreeBSD image on Azure (sponsored by the FreeBSD Foundation and Microsoft), and we received this modification suggestion/request from Azure Application Certification Support when validating our image, and we have to make this change to get our image approved. So, I believe this is a sane default from the view of FreeBSD project and Azure. My goal is letting unmodified azure-agent can run well on FreeBSD by default. Hope this is a good reason and helps you review this change.

[trstringer]

Looks good to me. @anhvoms, can I get a second opinion on this config change?

[trstringer]

Chatted with @anhvoms and he's good with the change.

[narrieta]

@vrdmr @larohra - could you check this PR?

[larohra]

LGTM

[lwhsu]

Thanks everyone's help! We'll continue working more on providing good user experience of FreeBSD on Azure.