Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set log time format #1737

Merged
merged 3 commits into from
Dec 16, 2019
Merged

Set log time format #1737

merged 3 commits into from
Dec 16, 2019

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Dec 16, 2019

Description

datetime.isoformat() skips ms if ms=0, this PR replaces using isoformat with a specific ISO 8601 format that always include micro seconds.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Dec 16, 2019

Codecov Report

Merging #1737 into develop will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1737   +/-   ##
========================================
  Coverage    68.21%   68.21%           
========================================
  Files           80       80           
  Lines        11617    11617           
  Branches      1635     1635           
========================================
  Hits          7924     7924           
  Misses        3356     3356           
  Partials       337      337
Impacted Files Coverage Δ
azurelinuxagent/common/logger.py 93.86% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 44d4de1...e6b9103. Read the comment docs.

@vrdmr vrdmr added this to the v2.2.46 milestone Dec 16, 2019
@larohra larohra merged commit 435dd44 into Azure:develop Dec 16, 2019
rjschwei pushed a commit to rjschwei/WALinuxAgent that referenced this pull request Mar 24, 2020
* Modified log time format
@larohra larohra deleted the SetLogTimeFormat branch April 22, 2020 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants