Start sending additional memory information per process #1729
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #1729 +/- ##
==========================================
Coverage ? 68.39%
==========================================
Files ? 81
Lines ? 11741
Branches ? 1648
==========================================
Hits ? 8030
Misses ? 3369
Partials ? 342
Continue to review full report at Codecov.
|
Adding the default process_name, process_commandline
- Making it more explicit for Memory cases as well if IOError came. - Adding a filter to make sure not adding entries into Metrics which are marked_for_delete - Tests changes
Did some tweaks to make it mergable in test_cgroups and test_cgroupstelemetry.
vrdmr
commented
Dec 12, 2019
narrieta
reviewed
Dec 13, 2019
- cgroups.py - cleaner returns and raises - cgroupstelemetry.py - exception handling when proc_statm for pid fails. - exception.py - cgroup comments fixed - resourceusage.py - raising exception when failing to get memory info. - monitor.py - reverted the reset_logger changes - test_cgroupstelemetry.py - stray print and mock removed. - test_resourceusage.py - newline and end - test_monitor.py - removed reset_logger changes, and count of metrics fixed.
- resourceusage.py - Propogate IOError(Errno2) above, and for other exceptions, raise ProcessInfoException. - test_resourceusage.py - Add more asserts to check the raising of IOError, ProcessInfoException.
- cgroupstelemetry.py - handling of exception thrown by get_proc_*. Also some variable name refactoring. - resourceusage.py - Bubbling up exceptions in get_proc_* - test_cgroupstelemetry.py - Refactoring variable name. - test_resourceusage.py - Changes in test to test exception bubbling up.
narrieta
reviewed
Dec 13, 2019
- test_cgroups.py - Simple refactoring of class setup and asserts fixed for get_tracked_process - resourceusage.py - Comments fixed. - cgroupstelemetry.py - Refactored the strings into class for easy usage. - cgroup.py - Refactoring the controller names strings into class. Also changed get_tracked_processes's return behavior.
narrieta
approved these changes
Dec 16, 2019
larohra
approved these changes
Dec 16, 2019
rjschwei
pushed a commit
to rjschwei/WALinuxAgent
that referenced
this pull request
Mar 24, 2020
* Adding ResourceUsage Class and Adding ProcessIds in Telemetry * Adding process tests to fetch the processes in cgroup * Sending Resource Metrics for Memory Usage telemetry. * Sending Memory Data for Tracked Processes * Fix proc_statm collection and dictionary formatting * Updating the process_name pattern when sending memory telemetry * Adding the default process_name, process_commandline * Handling inactive cgroups; not send empty values in ExtensionMetricsData - Making it more explicit for Memory cases as well if IOError came. - Adding a filter to make sure not adding entries into Metrics which are marked_for_delete - Tests changes * Fixing the missed test - Changing the memory exceptions. * Review Comments addressed, and clearer exception handling. - cgroups.py - cleaner returns and raises - cgroupstelemetry.py - exception handling when proc_statm for PID fails. - exception.py - cgroup comments fixed - resourceusage.py - raising an exception when failing to get memory info. - monitor.py - reverted the reset_logger changes - test_cgroupstelemetry.py - stray print and mock removed. - test_resourceusage.py - newline and end - test_monitor.py - removed reset_logger changes, and count of metrics fixed. * Making IOError explicit for get_memory_usage_proc_statm & test fixes - resourceusage.py - Propogate IOError(Errno2) above, and for other exceptions, raise ProcessInfoException. - test_resourceusage.py - Add more asserts to check the raising of IOError, ProcessInfoException. * Addressing review comments. - cgroupstelemetry.py - handling of exception thrown by get_proc_*. Also, some variable name refactoring. - resourceusage.py - Bubbling up exceptions in get_proc_* - test_cgroupstelemetry.py - Refactoring variable name. - test_resourceusage.py - Changes in test to test exception bubbling up. * Initializing a new logger for each test here to not conflict with others * Review comments addressed and some refactoring. - test_cgroups.py - Simple refactoring of class setup and asserts fixed for get_tracked_process - resourceusage.py - Comments fixed. - cgroupstelemetry.py - Refactored the strings into class for easy usage. - cgroup.py - Refactoring the controller names strings into class. Also changed get_tracked_processes' return behavior.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding proc_statm check to validate the memory values we get from CGroup.
Sample event would look like
PR information
Quality of Code and Contribution Guidelines
This change is