Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor adding the common fields to single method #1707

Merged
merged 6 commits into from
Nov 19, 2019
Merged

Refactor adding the common fields to single method #1707

merged 6 commits into from
Nov 19, 2019

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Nov 10, 2019 •
edited
Loading

Description

To bring the logic of adding all the common fields into one method.

Issue #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

This change is Reviewable

@codecov
Copy link

codecov bot commented Nov 10, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@5ef3e86). Click here to learn what that means.
The diff coverage is 86.95%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1707   +/-   ##
==========================================
  Coverage           ?   68.02%           
==========================================
  Files              ?       80           
  Lines              ?    11573           
  Branches           ?     1624           
==========================================
  Hits               ?     7873           
  Misses             ?     3361           
  Partials           ?      339
Impacted Files Coverage Δ
azurelinuxagent/common/telemetryevent.py 100% <ø> (ø)
azurelinuxagent/ga/monitor.py 88.34% <100%> (ø)
azurelinuxagent/common/event.py 84.24% <100%> (ø)
azurelinuxagent/common/future.py 39.28% <25%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5ef3e86...3ae9e05. Read the comment docs.

narrieta
narrieta previously approved these changes Nov 14, 2019
View reviewed changes
Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved with one suggestion

azurelinuxagent/common/future.py Outdated Show resolved Hide resolved
larohra
larohra reviewed Nov 15, 2019
View reviewed changes
tests/common/test_event.py Outdated Show resolved Hide resolved
larohra
larohra approved these changes Nov 16, 2019
View reviewed changes
Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrdmr vrdmr merged commit 7136b9b into Azure:develop Nov 19, 2019
@vrdmr vrdmr deleted the vameru/refactor-default-fields-logic branch November 22, 2019 01:14
@vrdmr vrdmr added this to the v2.2.46 milestone Dec 3, 2019
rjschwei pushed a commit to rjschwei/WALinuxAgent that referenced this pull request Mar 24, 2020
@vrdmr @rjschwei
Refactor adding the common fields to single method (Azure#1707)
a526d65 
* Refactor adding the common fields to a single method
* Resolving the import issues.
* Moving the imports into sys.version check.
* Review Comments and Refactoring of Tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@narrieta narrieta narrieta approved these changes

@larohra larohra larohra approved these changes

@pgombar pgombar Awaiting requested review from pgombar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v2.2.46
Development

Successfully merging this pull request may close these issues.
3 participants
@vrdmr @narrieta @larohra