Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use alternate systemd detection #1677

Merged
merged 2 commits into from
Oct 23, 2019
Merged

use alternate systemd detection #1677

merged 2 commits into from
Oct 23, 2019

Conversation

narrieta
Copy link
Member

@narrieta narrieta commented Oct 22, 2019 •
edited by vrdmr
Loading

  • Replacing run_get_output with run_command (errors were being ignored, since run_get_output does not throw)
  • The new logic to detect systemd uses the same check as systemd itself (e.g. systemd-run).

This change is Reviewable

@narrieta
Copy link
Member Author

DCR run OK

@codecov
Copy link

codecov bot commented Oct 22, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (develop@93ecdc4). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             develop   #1677   +/-   ##
=========================================
  Coverage           ?   67.3%           
=========================================
  Files              ?      80           
  Lines              ?   11297           
  Branches           ?    1579           
=========================================
  Hits               ?    7603           
  Misses             ?    3364           
  Partials           ?     330
Impacted Files Coverage Δ
azurelinuxagent/common/cgroupapi.py 79.41% <100%> (ø)
azurelinuxagent/common/utils/shellutil.py 66.26% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 93ecdc4...41526c6. Read the comment docs.

pgombar
pgombar approved these changes Oct 23, 2019
View reviewed changes
Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narrieta narrieta merged commit b01e28c into Azure:develop Oct 23, 2019
@narrieta narrieta mentioned this pull request Oct 23, 2019
Merged
@narrieta narrieta deleted the systemd-detection branch October 28, 2019 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vrdmr vrdmr vrdmr approved these changes

@pgombar pgombar pgombar approved these changes

@larohra larohra Awaiting requested review from larohra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@narrieta @vrdmr @pgombar