Start sending Execution Mode in the Telemetry #1657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrdmr
commented
Oct 7, 2019
azurelinuxagent/ga/monitor.py
Outdated
Comment on lines
282
to
293
| copy_param = [] | ||
|
|
||
| for param in event.parameters: | ||
| if param.name in sysinfo_names: | ||
| logger.verbose("Remove existing event parameter: [{0}:{1}]", param.name, param.value) | ||
| event.parameters.remove(param) | ||
| event.parameters.extend(self.sysinfo) | ||
| if param.name not in sysinfo_names: | ||
| logger.verbose("Adding existing event parameter: [{0}:{1}]", param.name, param.value) | ||
| copy_param.append(param) | ||
| else: | ||
| logger.verbose("Removing existing event parameter: [{0}:{1}]", param.name, param.value) | ||
|
|
||
| copy_param.extend(self.sysinfo) | ||
| event.parameters = copy_param | ||
|
|
There was a problem hiding this comment.
The earlier logic doesn't cleanly remove items from the list. When the fields to be removed come next to each other in the list, the list.remove would stip the second occurrence of the item to be removed.
Codecov Report
@@ Coverage Diff @@
## develop #1657 +/- ##
===========================================
+ Coverage 66.92% 67.14% +0.21%
===========================================
Files 78 78
Lines 11263 11266 +3
Branches 1575 1575
===========================================
+ Hits 7538 7564 +26
+ Misses 3402 3379 -23
Partials 323 323
Continue to review full report at Codecov.
|
pgombar
reviewed
Oct 8, 2019
pgombar
approved these changes
Oct 8, 2019
6 tasks
narrieta
approved these changes
Oct 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sending
ExecutionModefield when sending telemetry events.PR information
Quality of Code and Contribution Guidelines
This change is