Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaning zip packages correctly during uninstall/update. #1642

Merged
merged 4 commits into from
Sep 30, 2019

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Sep 23, 2019

Description

Cleaning up zip packages correctly during uninstall and update.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@narrieta
Copy link
Member

@vrdmr Travis failed

@vrdmr
Copy link
Member Author

vrdmr commented Sep 24, 2019

@narrieta - Yes. Working on fixing the tests.

@codecov
Copy link

codecov bot commented Sep 26, 2019

Codecov Report

❗ No coverage uploaded for pull request base (develop@9687794). Click here to learn what that means.
The diff coverage is 70%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop    #1642   +/-   ##
==========================================
  Coverage           ?   66.78%           
==========================================
  Files              ?       78           
  Lines              ?    11237           
  Branches           ?     1577           
==========================================
  Hits               ?     7505           
  Misses             ?     3406           
  Partials           ?      326
Impacted Files Coverage Δ
azurelinuxagent/ga/exthandlers.py 83.38% <70%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9687794...3f90f5f. Read the comment docs.

Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tests/ga/test_extension.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
Copy link
Contributor

@larohra larohra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants