Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension update on failure return based reporting #1634

Merged

Conversation

larohra
Copy link
Contributor

@larohra larohra commented Sep 16, 2019

Description

Currently the update sequence of an extension consists of the following operations -
Disable (OV) -> Update (NV) -> Uninstall (OV) -> Install if updateMode == UpdateWithInstall (NV) -> Enable (NV).

This PR addresses the issue where Extension Updates are blocked if there's any failure in the old version of the Extension. We've introduced a new flag 'continueOnUpdateFailure' which can be set in the new HandlerManifer of the extension to unblock the extension update.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion

azurelinuxagent/ga/exthandlers.py Show resolved Hide resolved
@larohra larohra merged commit 0105f5f into Azure:develop Sep 17, 2019
@larohra larohra deleted the ExtensionUpdateOnFailureReturnBasedReporting branch September 23, 2019 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants