Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary code from is_cgroups_supported #1599

Merged
merged 1 commit into from
Aug 1, 2019

Conversation

pgombar
Copy link
Contributor

@pgombar pgombar commented Aug 1, 2019

Description

Remove leftover and incorrect code that references WSL and Trusty. The only criteria for determining if cgroups is supported is if the path /sys/fs/cgroups exists or not.

Issue #1597


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Aug 1, 2019

Codecov Report

Merging #1599 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1599      +/-   ##
===========================================
+ Coverage    66.01%   66.02%   +<.01%     
===========================================
  Files           77       77              
  Lines        11053    11048       -5     
  Branches      1559     1558       -1     
===========================================
- Hits          7297     7294       -3     
+ Misses        3421     3420       -1     
+ Partials       335      334       -1
Impacted Files Coverage Δ
azurelinuxagent/common/osutil/default.py 57.73% <100%> (-0.02%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bbfeb9...26aa92b. Read the comment docs.

@pgombar pgombar merged commit b0420fd into Azure:develop Aug 1, 2019
@pgombar pgombar deleted the refactor_cgroups_supported branch August 1, 2019 22:02
@plessisa
Copy link
Contributor

plessisa commented Aug 28, 2019

Do we know what is the release targeted to this fix? Seems like it did not made it to 2.2.42.

@narrieta
Copy link
Member

@plessisa - we are targeting a release by end of next week

@narrieta
Copy link
Member

Fixes #1597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants