Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle errors in individual controllers #1570

Merged
merged 1 commit into from
Jun 28, 2019

Conversation

narrieta
Copy link
Member

@narrieta narrieta commented Jun 28, 2019

Added try/except to _for_each_controller


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #1570 into develop will not change coverage.
The diff coverage is 81.25%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1570   +/-   ##
========================================
  Coverage    63.37%   63.37%           
========================================
  Files           78       78           
  Lines        11058    11058           
  Branches      1559     1559           
========================================
  Hits          7008     7008           
  Misses        3711     3711           
  Partials       339      339
Impacted Files Coverage Δ
azurelinuxagent/common/cgroupapi.py 62.5% <81.25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b581fdc...d766842. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jun 28, 2019

Codecov Report

Merging #1570 into develop will not change coverage.
The diff coverage is 81.25%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop    #1570   +/-   ##
========================================
  Coverage    63.37%   63.37%           
========================================
  Files           78       78           
  Lines        11058    11058           
  Branches      1559     1559           
========================================
  Hits          7008     7008           
  Misses        3711     3711           
  Partials       339      339
Impacted Files Coverage Δ
azurelinuxagent/common/cgroupapi.py 62.5% <81.25%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b581fdc...d766842. Read the comment docs.

Copy link
Contributor

@pgombar pgombar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@narrieta narrieta merged commit 432a461 into Azure:develop Jun 28, 2019
@narrieta narrieta deleted the controller-error branch June 28, 2019 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants