Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix EventError argument for logging IOError correctly #1506

Merged
merged 1 commit into from
Jun 25, 2019

Conversation

taoyama
Copy link
Contributor

@taoyama taoyama commented Apr 15, 2019

Fix EventError argument for logging IOError correctly

I found IOError is not properly logged when Agent fails to save event.
This patch would fix the issue.

Issue #


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines


This change is Reviewable

@codecov
Copy link

codecov bot commented Apr 15, 2019

Codecov Report

Merging #1506 into develop will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #1506      +/-   ##
===========================================
- Coverage    60.82%   60.82%   -0.01%     
===========================================
  Files           75       75              
  Lines        10878    10879       +1     
  Branches      1559     1559              
===========================================
  Hits          6617     6617              
- Misses        3946     3947       +1     
  Partials       315      315
Impacted Files Coverage Δ
azurelinuxagent/common/event.py 80% <0%> (-0.31%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4c7c892...af3e41e. Read the comment docs.

@taoyama
Copy link
Contributor Author

taoyama commented Jun 13, 2019

Any comment on this?

Copy link
Member

@vrdmr vrdmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks for the change.

@vrdmr vrdmr merged commit 5547272 into Azure:develop Jun 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants