Use 1804-style deprovisioning for all versions >= 18.04 #1483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
"It looks like systemd is here to stay, though, so the change in deprovisioning for 18.04 should apply to all versions of Ubuntu since (and including) 18.04." Ubuntu 16.04 also uses systemd. Why are we not using systemd-aware deprovisioning, as you put it, for 16.04 as well? |
|
The comments on #1151 tell the story:
This isn't so much about systemd as it is about the transition to netplan and networkd, which weren't involved in managing /etc/resolv.conf in 16.04 despite the use of systemd. Feel free to change the commit comment. Other distros are already handled by distro-specific deprovision handlers which accommodate the platform's preferred way of managing /etc/resolv.conf. The code in question literally surrounds the one line I touched. |
pgombar
added a commit
that referenced
this pull request
May 2, 2019
* Use 1804-style deprovisioning for all versions >= 18.04 (#1483) 18.04 changed the method of managing resolv.conf vs. 16.04; the new method involves letting systemd-networkd manage that file. A previous fix corrected waagent behavior for 18.04 but did not do so for subsequent releases. Now that Ubuntu's direction is clear, this commit makes the correction in all versions of Ubuntu from 18.04 onwards. Other distros are unaffected by this bug and by this fix. * Updating Travis settings * Added description for Extension Error Codes (#1482) * Added description for Extension Error Codes * Correcting the test - to send the correct CRP Extension Error code * Adding docstring to describe ExtensionErrorCodes * Make launch_command resilient to cgroups failures (#1484) * WireServer Certificates parser gracefully exits if format of package is not Pkcs7BlobWithPfxContents (#1474) * Certificates parser gracefully exits if format of package is not Pkcs7BlobWithPfxContents * Add missing files * change message to warning * Removing the requirement of passing cipher-name. Default is more secure (#1481) * Fix PID tracking for cgroups (#1489) * add fixes for cgroup setup and PID tracking * cleanup code comments * disable cgroups test if not supported by environment * remove wrapper cgroup tracking and other nits * fix whitespace * nit fixes; addressing CR comments * Release 2.2.39 (#1494) * Fix header * Update agent version to 2.2.40
larohra
pushed a commit
to larohra/WALinuxAgent
that referenced
this pull request
Aug 21, 2019
* Use 1804-style deprovisioning for all versions >= 18.04 (Azure#1483) 18.04 changed the method of managing resolv.conf vs. 16.04; the new method involves letting systemd-networkd manage that file. A previous fix corrected waagent behavior for 18.04 but did not do so for subsequent releases. Now that Ubuntu's direction is clear, this commit makes the correction in all versions of Ubuntu from 18.04 onwards. Other distros are unaffected by this bug and by this fix. * Updating Travis settings * Added description for Extension Error Codes (Azure#1482) * Added description for Extension Error Codes * Correcting the test - to send the correct CRP Extension Error code * Adding docstring to describe ExtensionErrorCodes * Make launch_command resilient to cgroups failures (Azure#1484) * WireServer Certificates parser gracefully exits if format of package is not Pkcs7BlobWithPfxContents (Azure#1474) * Certificates parser gracefully exits if format of package is not Pkcs7BlobWithPfxContents * Add missing files * change message to warning * Removing the requirement of passing cipher-name. Default is more secure (Azure#1481) * Fix PID tracking for cgroups (Azure#1489) * add fixes for cgroup setup and PID tracking * cleanup code comments * disable cgroups test if not supported by environment * remove wrapper cgroup tracking and other nits * fix whitespace * nit fixes; addressing CR comments * Release 2.2.39 (Azure#1494) * Fix header * Update agent version to 2.2.40
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable systemd-aware deprovisioning on all versions >= 18.04
Issue #1476
The fix for #1151 was hard-coded to apply only to 18.04. It looks like systemd is here to stay, though, so the change in deprovisioning for 18.04 should apply to all versions of Ubuntu since (and including) 18.04.
PR information
Quality of Code and Contribution Guidelines