Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log the actual exceptions for metadata retry paths. #1441

Merged
merged 4 commits into from
Jan 12, 2019
Merged

log the actual exceptions for metadata retry paths. #1441

merged 4 commits into from
Jan 12, 2019

Conversation

adepue
Copy link
Member

@adepue adepue commented Jan 11, 2019

Description

Issue #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

vrdmr and others added 4 commits January 4, 2019 23:23
@vrdmr
Update issue templates (Azure#1438)
2c905b0 
Adding a BugReport template for gathering context better.
@narrieta
run_get_output: log expected errors as info (Azure#1437)
f3df4f3 
* run_get_output: log expected errors as info

* add extra checks

* python 3.4 compat

* python 3.4 compat
@adepue
log the actual exceptions for metadata retry paths. Catching non expl…
0ccb26a 
…icit exception types hides the problems.
@adepue
Ensure we dont accidentally process any response body during 304 in m…
baf9e18 
…etadata server
@adepue
Copy link
Member Author

adepue commented Jan 11, 2019

@narrieta @vrdmr for review

@narrieta
Copy link
Member

running automation....

@narrieta narrieta changed the base branch from master to release-2.2.35 January 12, 2019 00:16
@narrieta narrieta merged commit bff7805 into Azure:release-2.2.35 Jan 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adepue @narrieta @vrdmr