Add systemd support for Debian Jessie, Stretch, and Buster #1419
Conversation
jeking3
changed the title
jeking3
force-pushed
the
debian-buster
branch
from
43f6ede
to
4ba5ceb
Compare
|
|
setup.py
Outdated
| @@ -158,6 +160,11 @@ def get_data_files(name, version, fullname): | |||
| set_conf_files(data_files, src=["config/debian/waagent.conf"]) | |||
| set_logrotate_files(data_files) | |||
| set_udev_files(data_files, dest="/lib/udev/rules.d") | |||
| # All Debian versions since Jessie use systemd | |||
There was a problem hiding this comment.
Does this means we will update for each new version of debian? Can't you just specify the old supported version and say the other ones use systemd ?
There was a problem hiding this comment.
I'd prefer to search for a package and see if it is installed... so I agree what's here is not currently optimal however it is an improvement over what was there before, which was no systemd support at all, and the agent wasn't starting (at least on buster, for me...)
There was a problem hiding this comment.
Some additional information on platforms, just tucking it away somewhere so I can use it later. Apparently it isn't so easy to identify debian releases with platform.dist() - of course it's been deprecated since python 2.6, but I have addressed that in another PR.
debian:jessie
>>> print(platform.dist())
('debian', '8.11', '')
debian:stretch
>>> print(platform.dist())
('debian', '9.7', '')
debian:buster
>>> print(platform.dist())
('debian', 'buster/sid', '')
There was a problem hiding this comment.
@plessisa please review the change, I removed the named comparison
jeking3
force-pushed
the
debian-buster
branch
from
4ba5ceb
to
ac61bdf
Compare
| @@ -177,6 +181,14 @@ def get_data_files(name, version, fullname): | |||
| return data_files | |||
|
|
|||
|
|
|||
| def debian_has_systemd(): | |||
There was a problem hiding this comment.
The use of debian_has_systemd() is cleaner than the earlier approach. Thanks for doing the change. 👍
|
Running Automation now. |
|
@jeking3 Dont know why TravisCI is stuck at the waiting status state. I kicked off a new build in TravisCI but it still did not report here. Does this need a new a new dummy commit? |
- cleaned up some minor flake8 warnings
jeking3
force-pushed
the
debian-buster
branch
from
ac61bdf
to
5e5e636
Compare
|
All set. I rebased on master. |
|
Running Automation one final time and I'll merge it when it passes. Thanks. |
Description
Adds support for waagent under Debian Jessie, Stretch, and Buster which all use systemd.
PR information
Quality of Code and Contribution Guidelines
This change is