Support for Linux Openwrt #1412

plessisa · 2018-12-03T11:29:06Z

Description

The WALinuxAgent does not support Linux Openwrt. The pull request allow to support it. There is a first Commit to bring basic support, then few additional commit to fix area that have to be handle specifically for Linux Openwrt

Issue #1380

This patch contains:

(changed) future.py
Read the Openwrt version file to determine if we are running on openwrt
(changed) azurelinuxagent/common/osutil/factory.py
Reference to class OpenWRTOSUtil
(new file) azurelinuxagent/common/osutil/openwrt.py
Add class OpenWRTOSUtil
(changed) azurelinuxagent/daemon/resourcedisk/factory.py
Reference to class OpenWRTResourceDiskHandler
(new file) azurelinuxagent/daemon/resourcedisk/openwrt.py
Add class OpenWRTResourceDiskHandler
(changed) bin/waagent2.0
Provide support for Openwrt action
(new file) init/openwrt/waagent
Provide init file for Openwrt
(changed) setup.py
Separate the workflow of Openwrt

PR information

The title of the PR is clear and informative.
There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
If applicable, the PR references the bug/issue that it fixes in the description.
New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

I have read the contribution guidelines.

msftclas · 2018-12-03T11:29:18Z

All CLA requirements met.

plessisa · 2018-12-07T13:07:50Z

Is there anything I can do to help the review?

jeking3

Left a few comments for you.

azurelinuxagent/common/future.py

azurelinuxagent/common/osutil/openwrt.py

azurelinuxagent/daemon/resourcedisk/openwrt.py

plessisa · 2019-01-09T14:22:20Z

@vrdmr, @narrieta Is there anything I can do to help the review of this code ?

vrdmr · 2019-01-11T07:26:22Z

Hi @plessisa, In our end to end tests with your PR, we are seeing the following errors showing up - Agent WALinuxAgent-2.2.34 launched with command 'python3 -u bin/WALinuxAgent-2.2.34-py2.7.egg -run-exthandlers' failed with return code: 1 on Debian systems. We need to investigate more. IMT, could you please rebase your branch with the current upstream master to make sure the recent stdout/stderr fixes are in? Thanks.

Signed-off-by: Plessis <aplessis@rbbn.com>

Signed-off-by: Plessis Adrien <adr.plessis@gmail.com>

Signed-off-by: Plessis <aplessis@rbbn.com> Fix indentation issue Signed-off-by: Plessis <aplessis@rbbn.com>

plessisa · 2019-01-11T10:25:10Z

Hi @vrdmr, I rebased the PR today. I will investigate this issue on Debian.

vrdmr · 2019-01-11T16:53:48Z

Thanks. I'll start another series of tests based on your fork:branch. Thanks.

…

On Fri, Jan 11, 2019 at 2:25 AM plessisa ***@***.***> wrote: Hi @vrdmr <https://github.com/vrdmr>, I rebased the PR today. I will investigate this issue on Debian. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1412 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA_6AAZjBn_9QnJ4_Qm2OnIXQZ0KJyVMks5vCGaIgaJpZM4Y-ZHg> .

Signed-off-by: Plessis <aplessis@rbbn.com>

plessisa · 2019-01-23T15:51:36Z

@vrdmr I am not able to reproduce this issue on Debian. Can you?

plessisa · 2019-02-11T16:53:59Z

Hi @narrieta Any chance you can complete this review? Seems like @vrdmr is not available.

narrieta · 2019-02-11T18:56:51Z

@plessisa Sorry for the delay -- I'll try to look into this next week - this week is fully booked

vrdmr · 2019-02-20T22:39:15Z

@narrieta - Integration tests passed. Automation OK.

vrdmr

LGTM.

@narrieta - Could you please take a second look.

vrdmr · 2019-02-20T22:42:03Z

bin/waagent2.0

@@ -2156,6 +2157,132 @@ class FreeBSDDistro(AbstractDistro):
    def routeAdd(self, net, mask, gateway):
        Run("/sbin/route add -net " + net + " " + mask + " " + gateway, chk_err=False)

+
+############################################################
+#	OpenWRTDistro


We are currently not supporting waagent2.0 version of the agent. This code is deprecated and you can remove this change from the PR.

OK, I did removed the wagent2.0 change

plessisa force-pushed the master branch 2 times, most recently from 47d3e61 to 71952d7 Compare December 3, 2018 12:21

jeking3 reviewed Dec 13, 2018

View reviewed changes

plessisa force-pushed the master branch 3 times, most recently from 9405d50 to 384125f Compare December 18, 2018 15:24

vrdmr self-requested a review January 11, 2019 07:26

Plessis added 4 commits January 11, 2019 10:49

General Support for Linux Openwrt

247a15e

Signed-off-by: Plessis <aplessis@rbbn.com>

Resource Disk support for Linux Openwrt

ffcc771

Signed-off-by: Plessis <aplessis@rbbn.com>

User provisioning support for Linux Openwrt

6d0c48a

Signed-off-by: Plessis Adrien <adr.plessis@gmail.com>

Networking support for Linux Openwrt

36d9be9

Signed-off-by: Plessis <aplessis@rbbn.com> Fix indentation issue Signed-off-by: Plessis <aplessis@rbbn.com>

plessisa force-pushed the master branch from 384125f to e920abd Compare January 11, 2019 10:00

Update for to avoid future flake8 errors

6602e0a

Signed-off-by: Plessis <aplessis@rbbn.com>

plessisa force-pushed the master branch from e920abd to 6602e0a Compare January 21, 2019 21:03

narrieta assigned vrdmr, narrieta and pgombar Feb 11, 2019

vrdmr approved these changes Feb 20, 2019

View reviewed changes

Reduce the logs when using static IP

54232a4

plessisa force-pushed the master branch from f7a77d2 to 54232a4 Compare February 21, 2019 14:33

vrdmr merged commit 169f89c into Azure:master Feb 22, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Support for Linux Openwrt #1412

Support for Linux Openwrt #1412

plessisa commented Dec 3, 2018

msftclas commented Dec 3, 2018 •

edited

Loading

plessisa commented Dec 7, 2018

jeking3 left a comment

plessisa commented Jan 9, 2019

vrdmr commented Jan 11, 2019

plessisa commented Jan 11, 2019

vrdmr commented Jan 11, 2019 via email

plessisa commented Jan 23, 2019

plessisa commented Feb 11, 2019

narrieta commented Feb 11, 2019

vrdmr commented Feb 20, 2019

vrdmr left a comment

vrdmr Feb 20, 2019

plessisa Feb 21, 2019

Support for Linux Openwrt #1412

Support for Linux Openwrt #1412

Conversation

plessisa commented Dec 3, 2018

Description

PR information

Quality of Code and Contribution Guidelines

msftclas commented Dec 3, 2018 • edited Loading

plessisa commented Dec 7, 2018

jeking3 left a comment

Choose a reason for hiding this comment

plessisa commented Jan 9, 2019

vrdmr commented Jan 11, 2019

plessisa commented Jan 11, 2019

vrdmr commented Jan 11, 2019 via email

plessisa commented Jan 23, 2019

plessisa commented Feb 11, 2019

narrieta commented Feb 11, 2019

vrdmr commented Feb 20, 2019

vrdmr left a comment

Choose a reason for hiding this comment

vrdmr Feb 20, 2019

Choose a reason for hiding this comment

plessisa Feb 21, 2019

Choose a reason for hiding this comment

msftclas commented Dec 3, 2018 •

edited

Loading