-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Honor metadata etag for get_certs path. #1401
Conversation
@narrieta for feedback |
Change looks ok. Running automation. |
@narrieta Seems that the etag value wasn't ever being passed up to the server either. I have added another commit here that addresses that. Let me know what you think. |
The entire restutil class here doesnt seem to honor the 304 response codes per the protocol. I am going to close this PR for now and will bring it back once we have fully verified the failure patterns. Sorry for the scramble @narrieta |
@adepue No problem, thanks! |
@narrieta I have updated to incorporate handling of 304 return codes in a way isolated to the metadata protocol only. Let me know what you think of the code structure. We have a setup we can test on once we are fine with the code approach. |
@narrieta Let me know if you have concerns with this approach/update at all. |
Looks good. Running automation |
Description
Issue #
PR information
Quality of Code and Contribution Guidelines