-
Notifications
You must be signed in to change notification settings - Fork 372
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Write Status file in WALA Lib folder and other nits #1384
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vrdmr
commented
Oct 31, 2018
Please add a test case(s). |
boumenot
approved these changes
Oct 31, 2018
vrdmr
force-pushed
the
vameru-status-blob-telemetry
branch
from
October 31, 2018 05:22
ab6ad7c
to
29f9bea
Compare
narrieta
reviewed
Oct 31, 2018
vrdmr
commented
Nov 1, 2018
jasonzio
reviewed
Nov 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't see who calls write_ext_handlers_status_to_info_file()
, but the code itself looks okay.
vrdmr
force-pushed
the
vameru-status-blob-telemetry
branch
from
November 1, 2018 05:47
35575e0
to
dfecd35
Compare
narrieta
approved these changes
Nov 1, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adding a status file, which gets updated whenever a new status file is uploaded. It contains relevant information required for debugging and troubleshooting.
other nit fixes. No new tests added as this is heavily tested in the
test_extensions.py
class.PR information
Quality of Code and Contribution Guidelines