Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Write Status file in WALA Lib folder and other nits #1384

Merged
merged 2 commits into from
Nov 1, 2018

Conversation

vrdmr
Copy link
Member

@vrdmr vrdmr commented Oct 31, 2018

Description

Adding a status file, which gets updated whenever a new status file is uploaded. It contains relevant information required for debugging and troubleshooting.

other nit fixes. No new tests added as this is heavily tested in the test_extensions.py class.


PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@boumenot
Copy link
Member

Please add a test case(s).

azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Show resolved Hide resolved
@vrdmr vrdmr force-pushed the vameru-status-blob-telemetry branch from ab6ad7c to 29f9bea Compare October 31, 2018 05:22
azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
azurelinuxagent/ga/exthandlers.py Outdated Show resolved Hide resolved
Copy link
Member

@jasonzio jasonzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't see who calls write_ext_handlers_status_to_info_file(), but the code itself looks okay.

azurelinuxagent/ga/exthandlers.py Show resolved Hide resolved
@vrdmr vrdmr force-pushed the vameru-status-blob-telemetry branch from 35575e0 to dfecd35 Compare November 1, 2018 05:47
Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vrdmr
Copy link
Member Author

vrdmr commented Nov 1, 2018

Thank @narrieta @boumenot

@vrdmr vrdmr merged commit c28805c into Azure:master Nov 1, 2018
@vrdmr vrdmr deleted the vameru-status-blob-telemetry branch November 2, 2018 00:01
@vrdmr vrdmr added this to the v2.2.35 milestone Jan 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants