Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add configuration for unlimited cgroups #1337

Merged
merged 1 commit into from
Sep 6, 2018
Merged

Add configuration for unlimited cgroups #1337

merged 1 commit into from
Sep 6, 2018

Conversation

hglkrijger
Copy link
Member

@hglkrijger hglkrijger commented Sep 6, 2018 •
edited
Loading

Description

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

narrieta
narrieta approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@narrieta narrieta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

jasonzio
jasonzio reviewed Sep 6, 2018
View reviewed changes
azurelinuxagent/common/conf.py

def get_cgroups_excluded(conf=__conf__):
excluded_value = conf.get("CGroups.Excluded", "customscript, runcommand")
return [s for s in [i.strip().lower() for i in excluded_value.split(',')] if len(s) > 0] if excluded_value else []
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

filter(str.len, map(str.lower, map(strip, excluded_value.split(',')))) if excluded_value else []

I kid. (Mostly.)

jasonzio
jasonzio approved these changes Sep 6, 2018
View reviewed changes
Copy link
Member

@jasonzio jasonzio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hglkrijger hglkrijger merged commit 527e863 into Azure:master Sep 6, 2018
@hglkrijger hglkrijger deleted the gh1330 branch September 6, 2018 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boumenot boumenot boumenot approved these changes

@narrieta narrieta narrieta approved these changes

@jasonzio jasonzio jasonzio approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hglkrijger @boumenot @narrieta @jasonzio