Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

- Handle the disapperance of net-tools #1290

Merged
merged 1 commit into from
Aug 8, 2018
Merged

- Handle the disapperance of net-tools #1290

merged 1 commit into from
Aug 8, 2018

Conversation

rjschwei
Copy link
Contributor

@rjschwei rjschwei commented Aug 7, 2018

  • Switch to the "ip route" commands dropping the previous implementation
    using the obsolete "route" comand.

Description

Issue #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • Except for special cases involving multiple contributors, the PR is started from a fork of the main repository, not a branch.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and Travis.CI is passing.

Quality of Code and Contribution Guidelines

@rjschwei
- Handle the disapperance of net-tools
170e286 
  + Switch to the "ip route" commands dropping the previous implementation
    using the obsolete "route" comand.
@rjschwei rjschwei mentioned this pull request Aug 7, 2018
Closed
@hglkrijger
Copy link
Member

hglkrijger commented Aug 7, 2018 •
edited
Loading

Test run passed on all endorsed distros.

hglkrijger
hglkrijger approved these changes Aug 8, 2018
View reviewed changes
Copy link
Member

@hglkrijger hglkrijger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@hglkrijger hglkrijger added this to the vNext milestone Aug 8, 2018
@hglkrijger hglkrijger merged commit 9df65e2 into Azure:master Aug 8, 2018
@rjschwei rjschwei deleted the route2 branch August 8, 2018 17:03
@hglkrijger
Copy link
Member

/cc @Artoria2e5 @kormic911 @Scotis @crea7or

Hi folks, please let us know if you have any feedback on this change.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hglkrijger hglkrijger hglkrijger approved these changes

@boumenot boumenot Awaiting requested review from boumenot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
vNext
Development

Successfully merging this pull request may close these issues.
2 participants
@rjschwei @hglkrijger