Clean up signal handling and sentinel file #1188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hglkrijger
commented
May 23, 2018
| @@ -382,7 +378,6 @@ def _emit_restart_event(self): | |||
| except Exception: | |||
| pass | |||
|
|
|||
| self._set_sentinal(msg="Starting") | |||
There was a problem hiding this comment.
Removing this is the primary fix here.
jasonzio
approved these changes
May 23, 2018
| # A SIGKILL handler is not being registered at this time to | ||
| # minimize perturbing the code. | ||
| if signum in (signal.SIGTERM, signal.SIGKILL): | ||
| if signum == signal.SIGTERM: |
There was a problem hiding this comment.
Dh you want to catch SIGQUIT as well?
There was a problem hiding this comment.
I thought SIGQUIT was a keyboard signal?
|
All we really do in the signal handler is clean up the sentinel and child processes, but we also do a cleanup on restart. So I think the value is purely in knowing 'something other than SIGTERM killed me', which is not actionable or imo very useful. I am going to merge, but happy to discuss further. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SIGTERMfrom the default handler we should callshutdown()SIGKILLcannot be caught, and we consider this to be a clean shutdown; instead only emit a sentinel on an unhandled error