Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Publish: Cascading version update #978

Merged
merged 25 commits into from
Feb 27, 2022
Merged

Conversation

MariusStorhaug
Copy link
Contributor

@MariusStorhaug MariusStorhaug commented Feb 6, 2022

Change

Main functionality changes:

  • Added ability to do cascading updates to "latest" versions for major and major.minor for Template Specs and Bicep Registry. This will allow consumers to specify a major, or major.minor version in the template reference. i.e.:
    • br:acr.azurecr.io/bicep/modules/microsoft.storage.storageaccount:1 to always get the latest non-breaking changes (features and patches/fixes) to their deployment,
    • br:acr.azurecr.io/bicep/modules/microsoft.storage.storageaccount:1.2 to only get the latest patches for their module reference, this in addition to the already able way with
    • br:acr.azurecr.io/bicep/modules/microsoft.storage.storageaccount:1.2.123 for a specific version.

Get-ModulesToUpdate

  • Rename script and functions from *Update -> *Publish to align better with its usage.
  • Reduce verbose logging where this was more noise than helpful

Pipelines:

Know issues:

Running the pipelines in ADO for a given module multiple times on the same commit will fail for the publishing step as it will attempt to publish a package using the same version which is not supported for ADO Universal Packages.

Type of Change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update (Wiki)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

Marius added 4 commits February 6, 2022 14:56
- Reduce verbose logging
- Add force run
- Cascading version updates for major and minor
@MariusStorhaug MariusStorhaug self-assigned this Feb 6, 2022
@MariusStorhaug MariusStorhaug added [cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] modules category: modules [cat] pipelines category: pipelines [cat] publishing category: publishing [prio] medium importance of the issue: medium priority labels Feb 6, 2022
@MariusStorhaug MariusStorhaug changed the title Added ability to forcefully publish modules New features for publish Feb 6, 2022
@MariusStorhaug MariusStorhaug marked this pull request as ready for review February 6, 2022 19:00
@MariusStorhaug MariusStorhaug linked an issue Feb 6, 2022 that may be closed by this pull request
@MariusStorhaug MariusStorhaug added this to the v 0.4 milestone Feb 7, 2022
@rahalan rahalan modified the milestones: v 0.4, v 0.5 Feb 21, 2022
@MariusStorhaug MariusStorhaug changed the title New features for publish Publish: Cascading version update Feb 26, 2022
@MariusStorhaug MariusStorhaug enabled auto-merge (squash) February 26, 2022 15:21
@MariusStorhaug MariusStorhaug force-pushed the users/mast/publishTrigger branch 6 times, most recently from a94de51 to f646a5f Compare February 26, 2022 16:32
@MariusStorhaug MariusStorhaug force-pushed the users/mast/publishTrigger branch from f646a5f to 86d3e91 Compare February 26, 2022 16:41
@MariusStorhaug MariusStorhaug force-pushed the users/mast/publishTrigger branch from d086f31 to 2faaf11 Compare February 26, 2022 17:14
@MariusStorhaug
Copy link
Contributor Author

Ready for review

@MariusStorhaug MariusStorhaug merged commit 87c5864 into main Feb 27, 2022
@MariusStorhaug MariusStorhaug deleted the users/mast/publishTrigger branch February 27, 2022 12:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] azure devops category: Azure DevOps [cat] github category: GitHub [cat] modules category: modules [cat] pipelines category: pipelines [cat] publishing category: publishing [prio] medium importance of the issue: medium priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reduce verbosity of publishing logic
3 participants