Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Synapse Private Link Hubs (#856) #858

Merged

Conversation

renepajta
Copy link
Member

@renepajta renepajta commented Jan 5, 2022

  • Added support for Synapse Private Link Hubs

  • Fixed typo in Github workflow

  • Create new workflow for deploying Synapse Private Link Hub

  • Added support for Locks, RBAC and Private Endpoints

  • Updated ReadMe file

  • Fixed outputs & updated ReadMe

  • Switched back to main branch

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr ASehr@hotmail.de

  • Fixed naming, added ADO pipeline, updated README

  • Removed TODOs in ReadMe

  • Reversed changes in auto-generated Readme to avoid conflicts

  • Remove lock settings from parameter file

  • Updated based on comments

  • Updated readme.md

Co-authored-by: Alexander Sehr ASehr@hotmail.de

Change

Feel free to remove this sample text

Thank you for your contribution !
Please include a summary of the change and which issue is fixed.
Please also include relevant motivation and context.
List any dependencies that are required for this change.

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • I'm sure there are no other open Pull Requests for the same update/change
  • My corresponding pipelines / checks run clean and green without any errors or warnings
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation (readme)
  • I did format my code

* Added support for Synapse Private Link Hubs

* Fixed typo in Github workflow

* Create new workflow for deploying Synapse Private Link Hub

* Added support for Locks, RBAC and Private Endpoints

* Updated ReadMe file

* Fixed outputs & updated ReadMe

* Switched back to main branch

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/.bicep/nested_rbac.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/deploy.bicep

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Update arm/Microsoft.Synapse/privateLinkHubs/readme.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>

* Fixed naming, added ADO pipeline, updated README

* Removed TODOs in ReadMe

* Reversed changes in auto-generated Readme to avoid conflicts

* Remove lock settings from parameter file

* Updated based on comments

* Updated readme.md

Co-authored-by: Alexander Sehr <ASehr@hotmail.de>
AlexanderSehr
AlexanderSehr previously approved these changes Jan 5, 2022
@AlexanderSehr AlexanderSehr added the [cat] modules category: modules label Jan 5, 2022
@AlexanderSehr AlexanderSehr linked an issue Jan 5, 2022 that may be closed by this pull request
@AlexanderSehr AlexanderSehr self-requested a review January 6, 2022 10:48
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) January 6, 2022 12:56
@AlexanderSehr AlexanderSehr merged commit d8b6812 into main Jan 6, 2022
@AlexanderSehr AlexanderSehr deleted the users/repajta/852_synapse_privatelinkhubs_module branch January 6, 2022 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[cat] modules category: modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement template for Synapse Private Link Hub
2 participants