Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prompt Variation Converter #86

Merged
merged 28 commits into from
Mar 13, 2024
Merged

Prompt Variation Converter #86

merged 28 commits into from
Mar 13, 2024

Conversation

jbolor21
Copy link
Contributor

@jbolor21 jbolor21 commented Mar 6, 2024 •
edited
Loading

Description

Adding a converter to create variations of a prompt

Tests

  • no new tests required
  • new tests added
  • existing tests adjusted

Documentation

  • no documentation changes needed
  • documentation added or edited
  • example notebook added or updated

@jbolor21 jbolor21 changed the title Prompt Variation Converter [WIP[ Prompt Variation Converter Mar 6, 2024
@jbolor21 jbolor21 changed the title [WIP[ Prompt Variation Converter [WIP] Prompt Variation Converter Mar 6, 2024
romanlutz
romanlutz reviewed Mar 6, 2024
View reviewed changes
Copy link
Contributor

@romanlutz romanlutz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for providing a first look at this! Looks great. I left a few high-level comments. Please ping me for another look before merging.

pyrit/datasets/attack_strategies/prompt_variation/prompt_variation.yaml Show resolved Hide resolved
pyrit/prompt_converter/variation_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/variation_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/variation_converter.py Outdated Show resolved Hide resolved
rlundeen2
rlundeen2 reviewed Mar 9, 2024
View reviewed changes
doc/code/converters.py Outdated Show resolved Hide resolved
rlundeen2
rlundeen2 approved these changes Mar 9, 2024
View reviewed changes
Copy link
Contributor

@rlundeen2 rlundeen2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reminder to update the title to remove [wip]

Sync with Roman for his comments; Looks great!

romanlutz
romanlutz reviewed Mar 9, 2024
View reviewed changes
tests/test_prompt_converter.py Show resolved Hide resolved
pyrit/prompt_converter/variation_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/variation_converter.py Outdated Show resolved Hide resolved
pyrit/prompt_converter/variation_converter.py Outdated Show resolved Hide resolved
doc/demo/converters.ipynb Outdated Show resolved Hide resolved
doc/code/converters.py Outdated Show resolved Hide resolved
doc/code/converters.ipynb Outdated Show resolved Hide resolved
pyrit/datasets/attack_strategies/prompt_variation/prompt_variation.yaml Show resolved Hide resolved
@jbolor21 jbolor21 changed the title [WIP] Prompt Variation Converter Prompt Variation Converter Mar 11, 2024
jbolor21 and others added 15 commits March 11, 2024 08:42
@jbolor21 jbolor21 merged commit 4b4d454 into Azure:main Mar 13, 2024
4 checks passed
@jbolor21 jbolor21 deleted the users/bjagdagdorj/promptVariation branch March 13, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@romanlutz romanlutz romanlutz left review comments

@rdheekonda rdheekonda rdheekonda left review comments

@rlundeen2 rlundeen2 rlundeen2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jbolor21 @romanlutz @rdheekonda @rlundeen2