FIX: Changed AzureSpeechTextToAudioConverter input_type to text and added converter input_supported tests #472
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
approved these changes
Oct 16, 2024
There was a problem hiding this comment.
It is somewhat concerning to me that tests didn't catch this. Can we add a test where we mock the TTS endpoint and pass (mocked) non-text data to have it raise? Or maybe that should be an issue to do it for all converters... yeah that's probably better. Can you create one? Input validation tests for all converters.
rlundeen2
reviewed
Oct 16, 2024
jsong468
changed the title
jsong468
force-pushed
the
AzureTTSInputFix
branch
from
aa78ed3 to
7e50990
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
AzureSpeechTextToAudioConverterclass, we mistakenly hadinput_typeof prompt asaudio_pathinstead oftest. This PR changes it totext.