-
Notifications
You must be signed in to change notification settings - Fork 423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MAINT: Crescendo and Score Refactor #405
Merged
rlundeen2
merged 7 commits into
Azure:main
from
rlundeen2:users/rlundeen/9_26_crescendo_bug
Oct 2, 2024
Merged
MAINT: Crescendo and Score Refactor #405
rlundeen2
merged 7 commits into
Azure:main
from
rlundeen2:users/rlundeen/9_26_crescendo_bug
Oct 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
romanlutz
reviewed
Oct 1, 2024
jsong468
reviewed
Oct 1, 2024
jsong468
reviewed
Oct 1, 2024
jsong468
reviewed
Oct 1, 2024
romanlutz
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was the result of walking through Crescendo and stepping through code. I believe it greatly simplifies the logic, and also greatly increases efficacy of Crescendo. Additionally, I refactored several scorers to simplify/reuse code.
Description
Tests and Documentation
Tests written. Crescendo Jupytext run; Running tree of attacks